- Issue created by @alexandru.dumitru
- 🇨🇭Switzerland saschaeggi Zurich
FYI
$suggestions[] = 'input__checkbox__toggle';
can't be removed as it will break core functionalities.So maybe better to move this issue to the
clientside_validation
. - 🇨🇭Switzerland saschaeggi Zurich
The problem being we need a way to identify checkbox groups, as Drupal doesn't provide an official way to do so.
See #2643012: Add property to identify if checkbox/radio is in group of checkboxes/radios → , maybe we could check for the integer/float type instead if that would solve this issue, otherwise we might have to close this as won't fix 👀
- Status changed to Needs work
7 months ago 8:06am 12 April 2024 - 🇨🇭Switzerland saschaeggi Zurich
@alexandru.dumitru would
if (!isset($variables['element']['#weight']) || !is_float($variables['element']['#weight'])) {
work to solve your issue?
PS: please use an MR instead of patches as we don't use patches anymore.
- 🇷🇴Romania alexandru.dumitru Cluj
What exactly core functionalities is it breaking? I tested it and checkbox groups look exactly the same with the input__checkbox__toggle suggestios, as css takes care of this case.
if (!isset($variables['element']['#weight']) || !is_float($variables['element']['#weight'])) {
This is the result if doing the above check. First item is integer, the second one is float.
- Assigned to sourojeetpaul
- Issue was unassigned.
- Status changed to Closed: cannot reproduce
7 months ago 1:15pm 17 April 2024 Hello there,
I've tried to reproduce the issue on my D10 instance with the specified version of the gin theme and the latest version of clientside validation module(4.0.2), But I doesn't seem to reproduce the issue.
After enabling those module and setting gin as the admin theme, all the toggle buttons are appearing as expected.
Attaching a screenshot for reference.
- Status changed to Active
7 months ago 2:26pm 22 April 2024 - Status changed to Fixed
6 months ago 8:12am 15 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.