🇫🇷France @xavier.masson

xavier.masson → created an issue.

I've removed the "disabled" property on the default option when using it to reset facet.

Rerolled the patch to apply cleanly against the latest codebase. No changes were made to the patch's logic or functionality.

I've rerolled the patch to align with the latest updates. The patch has been tested on Drupal 10.3.

xavier.masson → made their first commit to this issue’s fork.

xavier.masson → made their first commit to this issue’s fork.

I've rebased the MR !13 with latest version of 2.0.x, i've needed to adapt the previous code from changes of 2.0.x branch, any to review ?

xavier.masson → made their first commit to this issue’s fork.

@ajfwebdev Thanks for the review, I've fixed your comments on the MR.

xavier.masson → created an issue.

@larowlan you are right, the block template is overridden and doesn't fully render the `content' variable. I agree it fixes the problem, but is it legit to extend the BlockContentBlock cache methods with the encapsulated block content entity? Thanks!

xavier.masson → created an issue.

xavier.masson → made their first commit to this issue’s fork.

xavier.masson → created an issue.

xavier.masson → made their first commit to this issue’s fork.

Duplicate of Paths not set as expected when setActiveDomain() used → who's created the issue first.

In case we are in the Layout builder form does the label value must be directly generated for the AutoEntityLabelManager::ENABLED to avoid to have %AutoEntityLabel% displayed until to save the layout builder and invoke auto_entitylabel_entity_presave?

Like below :

case AutoEntityLabelManager::ENABLED:
        ...
        if (!empty($layout_builder_form)) {
          $widget['value']['#default_value'] = $entity->setLabel();
          $form['settings']['label_display']['#default_value'] = FALSE;
          $form['settings']['label_display']['#type'] = 'value';
        }
        break;

@codechefmarc i'll try to give a try to your work in progress to give some feedbacks.

I agree with @codechefmarc patch #21 doesn't work for me but #17 does.

The block form is generated from core/lib/Drupal/Core/Block/BlockPluginTrait.php line 173 :

    $form['label'] = [
      '#type' => 'textfield',
      '#title' => $this->t('Title'),
      '#maxlength' => 255,
      '#default_value' => $this->label(),
      '#required' => TRUE,
    ];

the interdiff between 17-21 merge oldly the $widget['value'] directly within the label (textfield form element) but after the #20 patch it was applied to nested elements as $form['settings']['label']['value].

-      $form['settings']['label'] = array_merge($form['settings']['label'], $widget['value']);
+     $form['settings']['label'] = array_merge($form['settings']['label'], $widget);

I've created also an temporary branch on the issue Rendering duplicate images when the original images have the same name but different extension 🐛 Rendering duplicate images when the original images have the same name but different extension RTBC with that fix applied, see the MR !33.

xavier.masson → changed the visibility of the branch 3281606-rendering-duplicate-images-and-dont-create-derivative to active.

xavier.masson → changed the visibility of the branch 3281606-rendering-duplicate-images-and-dont-create-derivative to hidden.

xavier.masson → made their first commit to this issue’s fork.

xavier.masson → created an issue.

Tested on Drupal 10.1 and Country path 8.x-1.6, the patch works great ! I had the same issue and with the patch the issue is fixed.

Thanks for the patch, the patch from #8 🐛 Ajax error on views with aggregation Postponed: needs info works as expected on Drupal core 9.5.11 !

Thanks for the patch ! The patch #2 🐛 TypeError: number_format(): Argument #1 ($num) must be of type float, string given in number_format() Postponed: needs info works great.

xavier.masson → created an issue. See original summary → .

Credit original author : DieterHolvoet → .

xavier.masson → created an issue.

I've tried the patch but doesn't fully work as expected as the patch only work with node entity type instead all the entity types fieldables. I'll try to find time to add support on all the entities types.

Thanks for the patch, i can confirm it works !

I've occurred the same issue with my HTML e-mail template broken with break lines in the Twig template converted as
HTML element. I've attached a patch to remove the usage of nl2br on the HTML body.

Maybe the module can provides some processors who users can enable or disable to be compliant for everyone.

I've reroll the patch for the 2.1.x and just applied the same code as applied in the Drupal core for that issue Html::transformRootRelativeUrlsToAbsolute() replaces "\r\n" with " \n" (#3311595) →

Reroll the patch to apply on the 1.14.0