πŸ‡«πŸ‡·France @xavier.masson

Haute-Normandie
Account created on 21 August 2014, almost 10 years ago
#

Merge Requests

Recent comments

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

In case we are in the Layout builder form does the label value must be directly generated for the AutoEntityLabelManager::ENABLED to avoid to have %AutoEntityLabel% displayed until to save the layout builder and invoke auto_entitylabel_entity_presave?

Like below :

case AutoEntityLabelManager::ENABLED:
        ...
        if (!empty($layout_builder_form)) {
          $widget['value']['#default_value'] = $entity->setLabel();
          $form['settings']['label_display']['#default_value'] = FALSE;
          $form['settings']['label_display']['#type'] = 'value';
        }
        break;

@codechefmarc i'll try to give a try to your work in progress to give some feedbacks.

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

I agree with @codechefmarc patch #21 doesn't work for me but #17 does.

The block form is generated from core/lib/Drupal/Core/Block/BlockPluginTrait.php line 173 :

    $form['label'] = [
      '#type' => 'textfield',
      '#title' => $this->t('Title'),
      '#maxlength' => 255,
      '#default_value' => $this->label(),
      '#required' => TRUE,
    ];

the interdiff between 17-21 merge oldly the $widget['value'] directly within the label (textfield form element) but after the #20 patch it was applied to nested elements as $form['settings']['label']['value].

-      $form['settings']['label'] = array_merge($form['settings']['label'], $widget['value']);
+     $form['settings']['label'] = array_merge($form['settings']['label'], $widget);
πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

I've created also an temporary branch on the issue Rendering duplicate images when the original images have the same name but different extension πŸ› Rendering duplicate images when the original images have the same name but different extension RTBC with that fix applied, see the MR !33.

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

xavier.masson β†’ changed the visibility of the branch 3281606-rendering-duplicate-images-and-dont-create-derivative to active.

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

xavier.masson β†’ changed the visibility of the branch 3281606-rendering-duplicate-images-and-dont-create-derivative to hidden.

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

Tested on Drupal 10.1 and Country path 8.x-1.6, the patch works great ! I had the same issue and with the patch the issue is fixed.

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie
πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

Thanks for the patch, the patch from #8 πŸ› Ajax error on views with aggregation Postponed: needs info works as expected on Drupal core 9.5.11 !

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

I've tried the patch but doesn't fully work as expected as the patch only work with node entity type instead all the entity types fieldables. I'll try to find time to add support on all the entities types.

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

Thanks for the patch, i can confirm it works !

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

I've occurred the same issue with my HTML e-mail template broken with break lines in the Twig template converted as
HTML element. I've attached a patch to remove the usage of nl2br on the HTML body.

Maybe the module can provides some processors who users can enable or disable to be compliant for everyone.

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

I've reroll the patch for the 2.1.x and just applied the same code as applied in the Drupal core for that issue Html::transformRootRelativeUrlsToAbsolute() replaces "\r\n" with " \n" (#3311595) β†’

πŸ‡«πŸ‡·France xavier.masson Haute-Normandie

Reroll the patch to apply on the 1.14.0

Production build 0.69.0 2024