[node:nid] not added in label in a certain combination of settings

Hello, I am facing this same issue.
The problem is that the module, if possible, fills the label in the presave hook where the entity ID is not yet available. And after the label is no longer considered empty and is not updated.

My solution is to add the ability to force the re-save of the label. To do this, a timestamp is written to the label for new entities that do not have an ID, which will also be considered empty. The new option in the form is called "Generate by re-saving"

I just tested the patch from #9 🐛 [node:nid] not added in label in a certain combination of settings Needs review and it works fine. Seems like a good solution!

Marking as RTBC.

+  /**
+   * The temporary label for prevent database errors.
+   */

Apart from some minor trouble in the patch which needs to be corrected/clarified, this issue is far behind and we need more reports if this issue is still reproducable at latest dev and latest stable release, which is 2 years younger than this issue here. Additionally the patch needs to be rerolled then for latest dev if the issue still persist. Than we can think about a backport if required for circumstances where older versions of this projeect are mandatory.

Apart from some minor trouble in the patch

The solution you quote is already used in this module. The patch just moves this string constant into a class constant for easy reuse.

This issue is still relevant, I have opened a merge request for the current version of the module.
I also added a test that reproduces the problem.

I would like the module to move to Gitlab CI → or fix Drupal CI for automated testing.
Because the default tests → fail via a deprecation error:

---Errors---
You are using the deprecated option "--no-suggest". It has no effect and will break in Composer 3.

@kksandr: Thanks for coming back on this!

It would be nice if the module switched to Gitlab CI or fixed Drupal CI for automated testing.

Feel free to open an issue for that. I would embrace that! +1

The solution you quote is already used in this module.

Minor misunderstanding: I was referring to minor gramma and typo in code comments.

Thanks for the reroll! +1 For all the hard work in here. Will review.

kksandr → closed merge request !17

xavier.masson → made their first commit to this issue’s fork.