🇦🇺Australia @amjad1233

amjad1233 → made their first commit to this issue’s fork.

I am getting same issue on Drupal 13. Turning off warmer for now.

hestenet → credited amjad1233 → .

hestenet → credited amjad1233 → .

amjad1233 → created an issue.

kim.pepper → credited amjad1233 → .

griffynh → credited amjad1233 → .

amjad1233 → created an issue.

fubarhouse → credited amjad1233 → .

Good old patch!

Waiting for https://github.com/szimek/signature_pad/issues/759 before proceeding with further development.

amjad1233 → made their first commit to this issue’s fork.

I understand and respect that CKEditor 4 is deprecated. To assist those transitioning to CKEditor 5, I have rewritten the patch for the "Contrib" module.

You're welcome! 😉

This is in the latest 3.0.1 release.

amjad1233 → created an issue.

The latest versions (Version 3) are all D10 compatible. We published the new version last week, so please refer to it.

+1 We are having the same issue.

Already fixed in 2.0.x-dev

amjad1233 → created an issue.

This is in the latest 3.0.0 Release

Thanks @gitmonkee,

LGTM.

Adding Patch for D10 Branch Diff

amjad1233 → created an issue.

I could not reproduce it.

Adding myself to the ping list.

Apologies for forgetting to attach the file in my previous message.

Good old patch !

amjad1233 → created an issue.

I am facing the same issue. It took long hours to run this one...

Please let me know if it all works.
Basically, you could add "Script" media anywhere to get the JS working.

amjad1233 → created an issue.

amjad1233 → created an issue.

Oh sorry just figured out that `visibility` in the config schema was changed to `content_readability_visibility` please ignore my previous comments

Re-opening, see my comments on MR.

quietone → credited amjad1233 → .

I couldn't find a button on the UI to delete the task. But when I navigated to `***/delete` manually, it did delete the task. However, two observations were made:
1. Even after deletion, it asked for a "Replacement Image Style". Why couldn't it be removed in the first place?
2. There's a very slim chance someone can delete the task outside of the UI.
- In any case, it does not sound like a bug. (in my opinion)

Hi @quietone,

+    if (isset($form[$langcode_key]) && (!isset($form[$langcode_key]['#access']) || $form[$langcode_key]['#access'] !== FALSE)) {
       $language_configuration = ContentLanguageSettings::loadByEntityTypeBundle($entity->getEntityTypeId(), $entity->bundle());
       $form[$langcode_key]['#access'] = $language_configuration->isLanguageAlterable();
     }

Looks good. In your experience with the patch, is it easy to add a test?

Did this get included in 8.x-5.2? I still see this issue in 8.x-5.2.

amjad1233 → created an issue.

Ah, that makes sense. Cool no worries we will give it another look. Thanks for that.

I agree too fixing seems to be a good approach since Test Traits 2 are bit more sensetive.

Hi @larowlan,

Thanks for your feedback.

Would you mind elaborating?

I think we need to $class_definition['multiple'] here, as an array is appropriate if that's TRUE, but NULL is appropriate if not.

In regards to `default: {}` I thought it was mandatory but makes sense.

Regards,
Amjad

@T.Barker the patch as per #2 seems to be missing tests.

Adding traditional patch.

amjad1233 → created an issue.

amjad1233 → created an issue.

Updated referenced issues and added traditional patch.

amjad1233 → created an issue.

A huge +1, maybe we can also ship some base standard components(optional) as part of distributions-and-recipes... https://www.drupal.org/about/core/strategic-initiatives-distributions-an... →

@andypost Thanks for the re-roll. 💪💪💪

I tried and patch applies cleanly and site also builds up fine.

patching file 'core/modules/user/src/Access/RoleAccessCheck.php'
patching file 'core/tests/Drupal/Tests/Core/Route/RoleAccessCheckTest.php'

Regarding Question 1 : I believe we are doing that already at certain places, but I agree with hiding as much as we can. With that said, I will defer question to @larowlan.

Regarding Question 2: I am not sure if this class will only be extended or there will be places where we create new instance of the class... In the later case Protected would fail. I think we should crack this one in 📌 Deprecate empty AccessInterface and remove usages Needs work . May be we explicitly define it's signature in interface.

Great suggestion let me get my hands dirty in this one.

Another stab at re-roll...

Against 9.5.x

Patch re-rolled for Drupal 9.5.3

amjad1233 → created an issue.

amjad1233 → created an issue.

Thanks @sergey-serov,

Really appreciated in coming days I will push changes and get it peer reviewed.

amjad1233 → created an issue.