- Issue created by @amjad1233
- Status changed to Closed: duplicate
about 1 year ago 8:30am 15 December 2023
Problem/Motivation:
There appears to be a compatibility issue in the magnific_popup module, specifically in the MagnificPopupMedia.php file. The method viewElements in MagnificPopupMedia class is not compatible with its parent class MagnificPopup. This is causing a PHP fatal error, hindering the module's functionality.
Steps to reproduce:
Install and enable the magnific_popup module on a Drupal site.
Attempt to use the Magnific Popup Media functionality.
Observe the PHP fatal error as described, occurring in MagnificPopupMedia.php on line 48.
Proposed Resolution:
I've developed a patch that resolves the compatibility issue by updating the viewElements method in the MagnificPopupMedia class. This update ensures that the method signature is compatible with its parent class, MagnificPopup.
Remaining Tasks:
Review and test the patch.
Commit the patch to the module if it passes review and testing.
Monitor for any additional feedback or issues post-implementation.
User Interface Changes:
No user interface changes are expected as a result of this patch. The fix is backend-oriented and should not affect the module's frontend display or functionality.
API Changes:
No API changes. The patch is intended to fix an existing method without altering the API.
Data Model Changes:
No data model changes. The patch focuses solely on resolving the method compatibility issue.
Patch File:
Patch Name: magnific_popup-compatibility-fix.patch
Description: This patch fixes the compatibility issue in the MagnificPopupMedia class by aligning the viewElements method signature with the parent class.
Location: (You can provide a link to the patch file or attach it directly to the issue).
Closed: duplicate
2.0
Code