Fix base prefix when generating URLs if index.php is in the path

Created on 10 December 2019, about 5 years ago

Updated 22 June 2024, 6 months ago

Problem/Motivation

Follow-up to ✨ Introduce a token to get site's base URL Fixed

Steps to reproduce:

Go to your installed drupal directory and append index.php (e.g http://drupal.test/index.php)
Build a URL with base prefix: Url::fromUri('base:sites/default/files/og_image.jpg')
Assert the URL to the image asset is broken as the path is /index.php/sites/default/files/og_image.jpg

Proposed resolution

When building a URL with base prefix use $request->getBasePath() instead of $request->getBaseUrl() which results in omitting index.php in case it is present.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Closed: duplicate

Version

11.0 🔥

Component

Routing →

Last updated 3 days ago

Maintained by
🇺🇸United States @tim.plunkett

Created by

mbovan

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇦🇺Australia amjad1233 Brisbane
I could not reproduce it.
Status changed to Closed: duplicate 6 months ago8:33am 22 June 2024
Comment 6 months ago →
🇬🇷Greece idimopoulos
Let's focus in a single ticket. This is an active bug-ish thing. Closing this as a duplicate of https://www.drupal.org/project/drupal/issues/3050261 🐛 index.php randomly appears in friendly URLs Active and adding the relevant link for anyone that is interested in (google pointed me to this link first).

Note that according to https://www.drupal.org/project/drupal/issues/3050261#comment-13118805 🐛 index.php randomly appears in friendly URLs Active , there is a working workaround to use redirect module's forced clean URLs to automatically remove the prefix on request.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024