Let me know if I need to test more things.
On a fresh Drupal 10 install, I repeated the error shown above. I applied the patch.
I tried adding a content type with content already in it after applying the patch. I configured search exclude to exclude this content type.
It worked.
I tried undoing this, and it is now showing up in the search as intended.
I added a content type with no entities and configured search exclude to exclude this content type. I added entities for this content type, and the content didn't show up as intended.
I configured search exclude to allow the above content type to show up in the search, and it worked as intended.
Nothing on the clean Drupal install seemed to be affected.
I tested Advanced Search in the same way as above.
The search exclude takes out the chosen content types as choices in the advanced search as well after I reran cron.
The SQL looks secure and correct.
I think the comments are sufficient.
The PHP Code looks like it conforms with Drupal coding standards
On a fresh Drupal 10 install, I repeated the error shown above. I applied the patch.
I tried adding a content type with content already in it after applying the patch. I configured search exclude to exclude this content type.
It worked.
I tried undoing this, and it is now showing up in the search as intended.
I added a content type with no entities and configured search exclude to exclude this content type. I added entities for this content type, and the content didn't show up as intended.
I configured search exclude to allow the above content type to show up in the search, and it worked as intended.
Nothing on the clean Drupal install seemed to be affected.
I tested Advanced Search in the same way as above.
The search exclude takes out the chosen content types as choices in the advanced search as well after I reran cron.
I'm going to do a code review in a bit.
@danflanagan8 , It looks like you put in tests for the patch. What do we need to make this Reviewed & tested by the community?
I made an update to #3461602: Core now allows moderation of taxonomy terms, but an error is thrown when trying to use scheduled transitions on this
Everything works with new terms, but my existing terms have the error mentioned there.
There is a workaround that I found: https://www.drupal.org/project/drupal/issues/3384600#comment-15214487 🐛 Don't hide permissions local tasks on bundles when no permissions are defined Needs work is a patch that can be applied to core 10.3.x and turn off the unneeded warnings.
Just to follow up, it seems to work okay on my site for new terms. My existing terms seem to have this issue.
I tried this and it seems to work as expected. But, there is an error thrown when trying to look at the revision log.
Guybrush Threepwood → created an issue.
Guybrush Threepwood → created an issue.
This patch worked for me! Thanks!
@gapple Thanks for the explanation. It was really helpful.
I applied the patch and am using latest stable CSP version with Drupal 10. I couldn't apply it using composer for some reason. Are there usage steps to make this patch work to make it so I don't have to use unsafe-inline?
I figured it out. I just uninstalled the module, and went to Webform display to set the field to checkboxes, and it works just like it did with the module.
Guybrush Threepwood → created an issue.