Core now allows moderation of taxonomy terms, but an error is thrown when trying to use scheduled transitions on this

Open on Drupal.org →

Created on 15 July 2024, 4 months ago

Updated 16 July 2024, 4 months ago

Problem/Motivation

As stated here: https://www.drupal.org/node/3424780 → , Core (10.3.x) now allows moderation of taxonomy terms.
Manually updating from draft to published works.
An error is thrown when trying to use scheduled transitions on this.

UPDATE:
I just tried to see the revision log and it threw an error there, this may be why I am getting the mentioned error

This error appears:

InvalidArgumentException: The timestamp must be numeric. in Drupal\Component\Datetime\DateTimePlus::createFromTimestamp() (line 201 of /web/core/lib/Drupal/Component/Datetime/DateTimePlus.php).

#0 /web/core/lib/Drupal/Core/Datetime/DateFormatter.php(121): Drupal\Component\Datetime\DateTimePlus::createFromTimestamp(NULL, Object(DateTimeZone), Array)
#1 /web/modules/contrib/scheduled_transitions/src/Form/Entity/ScheduledTransitionAddForm.php(404): Drupal\Core\Datetime\DateFormatter->format(NULL)
#2 [internal function]: Drupal\scheduled_transitions\Form\Entity\ScheduledTransitionAddForm->Drupal\scheduled_transitions\Form\Entity\{closure}(Object(Drupal\taxonomy\Entity\Term))
#3 /web/modules/contrib/scheduled_transitions/src/Form/Entity/ScheduledTransitionAddForm.php(381): array_map(Object(Closure), Array)
#4 /web/modules/contrib/scheduled_transitions/src/Form/Entity/ScheduledTransitionAddForm.php(92): Drupal\scheduled_transitions\Form\Entity\ScheduledTransitionAddForm->getRevisionOptions(Object(Drupal\taxonomy\Entity\Term))
#5 /web/core/lib/Drupal/Core/Entity/EntityForm.php(107): Drupal\scheduled_transitions\Form\Entity\ScheduledTransitionAddForm->form(Array, Object(Drupal\Core\Form\FormState))
#6 [internal function]: Drupal\Core\Entity\EntityForm->buildForm(Array, Object(Drupal\Core\Form\FormState))

Steps to reproduce

Add a workflow for a taxonomy
Enable it in scheduled transition settings and give a role permissions to take away message indicating roles aren't assigned to it
Go to the taxonomy term, I set it to draft
Go to the scheduled transitions tab
Click on the add scheduled transition button

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Closed: works as designed

Version

2.5

Component

Code

Created by

🇺🇸United States Guybrush Threepwood

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @Guybrush Threepwood
Comment 4 months ago →
🇺🇸United States Guybrush Threepwood
Comment 4 months ago →
🇦🇺Australia acbramley
See related core issue regarding the generic revision UI - we need to defend against empty timestamps 🐛 Protect against empty revision timestamps in VersionHistoryController::getRevisionDescription Active
Status changed to Closed: works as designed 4 months ago7:26am 16 July 2024
Comment 4 months ago →
🇦🇺Australia dpi Perth, Australia
Since \Drupal\Core\Entity\RevisionLogEntityTrait::getRevisionCreationTime guarantees a int, and Term entity is not returning an int, I'm considering:

Either a core bug: somehow values are non-int, by design. Or,

Data is malformed, for example during a migration or bad update. (I imagine its this). Or,

The interface maybe needs to be updated to return NULL.

In each of these, these are not an issue with scheduled transitions. Please consider a migration to fix the malformed data #2936995-85: Add taxonomy term revision UI →
Comment 4 months ago →
🇦🇺Australia dpi Perth, Australia
Commented in #3459169-5: Protect against empty revision timestamps in VersionHistoryController::getRevisionDescription →
Comment 4 months ago →
🇺🇸United States Guybrush Threepwood
Just to follow up, it seems to work okay on my site for new terms. My existing terms seem to have this issue.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024