Protect against empty revision timestamps in VersionHistoryController::getRevisionDescription

Created on 5 July 2024, 2 months ago
Updated 21 August 2024, 18 days ago

Problem/Motivation

People are seeing errors on Taxonomy revision pages when upgrading from 10.2 to 10.3, see πŸ“Œ Add taxonomy term revision UI RTBC

This is also being reported in πŸ› New revision fields don't have a default value after making an entity revisionable Active but that issue seems more general.

IMO we could be more defensive and check for NULL values before calling format() because as we know, Drupal is prone to field values not being there.

Steps to reproduce

From what I've read:

Start on 10.2
Create some terms
Upgrade to 10.3
Visit a term revisions page.

Proposed resolution

Add NULL checks in VersionHistoryController::getRevisionDescription for the revision creation time
Test coverage

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Active

Version

11.0 πŸ”₯

Component
EntityΒ  β†’

Last updated about 12 hours ago

Created by

πŸ‡¦πŸ‡ΊAustralia acbramley

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024