๐Ÿ‡ฎ๐Ÿ‡ณIndia @renukakulkarni

Account created on 23 May 2013, over 11 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

The root cause of the issue was identified my case. When the 'Disable the site email address' configuration is enabled, the recipient field is left empty, as written in the module code (screenshot attached).
When the 'from' address is empty, some email providers (except Gmail) block the emails from being sent. Therefore, if users wish to use the 'Roles' email functionality specifically, the 'Disable the site email address' option must be turned off in such cases, based on the current state of the code.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

This issue exists in version 8.x-3.6 as well.

When the 'Disable the site email address' and 'Email the author?' configurations are turned off, the selected roles do not receive any emails. Emails are only sent to roles when either of the above-mentioned configurations is enabled.

The email notification received by a user with the selected role has either the 'site email address' or the 'author email address' (whichever is enabled in the notification configuration) in the 'to' field.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

This issue is still present in version 3.1.1 of the module with Drupal 10.x. Even when the file is removed from the node, its entry is still present under files, and it gives the error 'used by another application.' Ideally, when the file is removed from the node and not used elsewhere, its entry should be deleted.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

@kanchan-bhogade,
I am able to reproduce this issue on Drupal 11 as well. Attached screencast for reference.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

Added a patch to address this behavior.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

Re-rolled the patch added in #119 โœจ Add poster image to HTML5 media videos Needs work as this was failing to apply for 10.2.x until this issue is merged into a stable release.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

Duplicate of https://www.drupal.org/project/google_directions/issues/3144335 ๐Ÿ“Œ Drupal 9 compatibility Closed: duplicate

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

MR https://git.drupalcode.org/project/webform_rules/-/merge_requests/2 will fix the issue which is occurring while enabling the module. But it seems the module is still using hooks which are already removed from the webform like hook_webform_submission_update, hook_webform_submission_delete which are resulting in an error. Those should get fixed in the porting issue - https://www.drupal.org/project/webform_rules/issues/2997447 ๐Ÿ’ฌ Port to D8/D9/D10 Needs review

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

This issue is not reproducible on vanilla Drupal 10.2.3. Module seems to be working fine. Please provide details if there are any other components added on homepage which are conflicting with this.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

This issue was caused because the margin area on the bottom of a form item was removed for this issue - https://www.drupal.org/project/gin/issues/3375729 ๐Ÿ› The autocomplete icon is not clearly visible when using dark mode. Fixed (https://git.drupalcode.org/project/gin/-/commit/0f4f88aef90989f49a91c89e...) This has affected the space between the form items.

I have checked the autocomplete field behavior after applying the code changes from the provided patch. It does not seem to be creating any issues, at least with the fields highlighted in the screenshot under this issue - https://www.drupal.org/project/gin/issues/3375729 ๐Ÿ› The autocomplete icon is not clearly visible when using dark mode. Fixed , and that fixes the space issue between the form items as well.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

Thank you so much for sharing this! It really helped.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

Created a patch from #13 ๐Ÿ“Œ Automated Drupal 10 compatibility fixes Fixed to use until D10 compatible non-dev release of the module is out.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

Re-rolled the patch for version 3.3.1.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

Patch from #12 ๐Ÿ“Œ Automated Drupal 10 compatibility fixes Fixed still produces the error -

Fatal error: Declaration of Drupal\jsonapi_schema\Normalizer\DataDefinitionNormalizer::supportsNormalization($data, ?string $format = null, array $context = []): bool must be compatible with Drupal\serialization\Normalizer\NormalizerBase::supportsNormalization($data, $format = null) in /var/www/fe-ecommerce-cms/docroot/modules/contrib/jsonapi_schema/src/Normalizer/DataDefinitionNormalizer.php on line 180

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

Re-rolled the patch to work with 8.6.1 until the 10 compatible non-dev release of the module is out.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

Re-rolled the patch to work with 8.5.2 until the 10 compatible release of the module is out.

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

@Maintainers - When the fix can be available in the non-dev release?

Thanks

๐Ÿ‡ฎ๐Ÿ‡ณIndia renukakulkarni

The issue is present in 3.1.4 version also.

Production build 0.71.5 2024