- Status changed to Needs review
almost 2 years ago 10:33am 24 January 2023 - 🇯🇴Jordan Rajab Natshah Jordan
Thank you, for having time to maintain the Max Length module.
Hoping for a soft commit to the
2.0.x-dev
, to ease testing with Drupal 10.
A soft tag release ( pre-release ) would help having a real physical testing withDrupal ~10.0
using the composer.Testing now with
git clone --branch '2.0.x' https://git.drupalcode.org/project/maxlength.git
And git apply for MR.diff/Patches - First commit to issue fork.
- 🇧🇪Belgium joevagyok
Committed the change for the theme, D10 is passing on CI now.
- 🇧🇪Belgium joevagyok
Updated the patch as well with the needed fix in the test files to make D10 CI pass.
- 🇯🇴Jordan Rajab Natshah Jordan
Thanks, Adam for the updated patch in #29
Had Real physical testing round for MaxLength
2.0.x-dev
with Drupal ~10
also
Had Real physical testing round for MaxLength2.0.x-dev
with Drupal ~9.0
Attached the bash command for the test
Real-physical-testing-round-for-maxlength-2-0-x-dev--with-d10-and-d9.zip →Working well with Drupal 9 and Drupal 10
But only withplane text
fields andCKEditor 4
Still not with CKEditor 5
Facing the 🐛 Countdown not working for ckeditor5 FixedWould you like to have a soft release ( pre-release ).
Still Drupal 9.5.x new insulation with the standard profile will face the issue with CKEditor 5
Drupal 10 will need to require CKEditor 4 deprecated module to work ( Tested ).
I'm with having 🐛 Countdown not working for ckeditor5 Fixed fixed first - 🇧🇪Belgium joevagyok
Thanks for the detailed tests and report. We are looking into the CKEditor 5 compatibility to make it work.
- 🇮🇹Italy kopeboy Milan
If too much work is still needed for CKEditor 5 compatibility, can't we release this for D10 only on (not long) plain text fields in the meantime?
- Status changed to RTBC
almost 2 years ago 11:11am 14 February 2023 -
joevagyok →
committed 0bb4dee7 on 2.1.x authored by
AaronBauman →
Issue #3295052 by Berdir, joevagyok, jasonawant, cedewey, noorulshameera...
-
joevagyok →
committed 0bb4dee7 on 2.1.x authored by
AaronBauman →
- Status changed to Fixed
almost 2 years ago 11:18am 14 February 2023 - 🇮🇳India renukakulkarni
@Maintainers - When the fix can be available in the non-dev release?
Thanks
- 🇧🇪Belgium joevagyok
There is the CKEditor 5 related issue that is important to support WYSIWYGs with CKEditor 5 in D10.
- 🇺🇸United States smustgrave
Wonder if there could be a beta release of 2.1.x
- 🇧🇪Belgium joevagyok
Yes, I will discuss it with the maintainers this week.
Automatically closed - issue fixed for 2 weeks with no activity.