πŸ‡³πŸ‡ΏNew Zealand @AndyD328

Lyttelton, NZ πŸ‡³πŸ‡Ώ
Account created on 21 August 2012, almost 12 years ago
#

Recent comments

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Hi Shawn,

In the text at the top:

Drupal module for OAuth2 clients, compatible with Drupal 7, Drupal 9, and Drupal 10. See the documentation guide for the appropriate version for details about implementation.

Drupal 7: 7.x-2.0 ===> this link goes to the relevant docs and is fine
Drupal 9.4+ & Drupal 10 (PHP 8.1): 4.1.x ===> this link goes to the releases page rather than the doc page for that version

It's not a big deal as the docs can be found easily enough but it seemed like it would make it less steps for users.

Cheers,

Andy

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ
πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Thanks Matt, released.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ
πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Thanks for the issue & patch, that was a bit of a wtf I left in the code.

I'll put this into a dev release and then into a new release in a few days if there's no issues. I made a change to the rate name setting in the contruction as otherwise the display name was always deftult. Also tidied up a messy if{} in isConfigured - my original mess, not yours.

Please test if you have a chance and let me know. Thanks!

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ
πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Thanks for the report & patch Dylan. I think my decision to use the default variation bundle is broken now that https://www.drupal.org/project/commerce/issues/3089040 ✨ Single product with multiple variation types Fixed is in core.

I've made a change to get the bundle of the variation being presented for purchase. It's a bit convoluted so if you can test it and let me know if you see a better route that would be awesome.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Hi,

The RC11 release is working well on a live site.

Thanks!

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Thanks for posting the link & workaround, very much appreciated!

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

The patch work for me. Many thanks auth.

Changing to major as it really is important to pick up custom patterns, borderline critical as it breaks the parts of a site without this patch.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Resolved elsewhere

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

I think I need the Edit permission too as that's where the Releases tab lives. I tried going direct to https://www.drupal.org/node/2454419/edit/releases β†’ and I get a 403.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Many thanks Adam. I've got a new tag sitting there with the updates from Gareth in it but I don't have permissions to create new releases. Can you add the 'Administer Releases' permission for me or add the 9.1.0 release to the module?

Many thanks!

And thanks to Gareth for making & testing the patch, it went in & worked without any issues.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Hi Goran,

Thanks for your reply. If there's an issue with the permissions we can probably get that sorted with the d.o team,

Cheers,

Andy

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Email sent to Adam through d.o contact form

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

I have contact gnikolovski through the d.o contact form as he is the last active maintainer.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

🌱 | Xero API | D10?
πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ
πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Awesome, thanks Julian!

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ made their first commit to this issue’s fork.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

I also had this and am also not sure if it is related.

It turned out that there was a second container hanging around in the config from an upgrade from v1.x
We uninstalled and re-installed so that the old container config was removed and it now appears to be working as expected.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Hi Adam,

I just wanted to ask if you were planning on a D10 release for this module? It's not exactly a project blocker, but it would be nice to have :-)

Thanks!

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

I just ran into this on upgrading to 1.3.0-rc1 from 1.2.1 as well but don't have anything to add to the

It seems from the above that we can either have the correct email template or have multiple BCC addresses, but not currently both. Is that correct?

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ
πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Just following up to see if there's been any movement - this is one of my D10 blockers :-) Thanks!

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Not moving 3.1 to D10

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Just following up if there will be a D10 release for this module? Many thanks!

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Patch is working here. Thanks!

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Closing this as 3317738 has now been committed to commerce core. Thanks everyone!

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

This is addressed in #3253200

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

AndyD328 β†’ created an issue.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ
πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ
πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Many thanks Richard, I appreciate you taking the time to roll a new dev release.

I tried pulling it in with composer and it got rejected - the dev release doesn't have the updates for 10 in it, but I was able to pull down the git repo, which does have it in. It then installed fine and the Anonymous Access provider on Nodes is working well. I haven't tried the Media provider.

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Hi, I would like to ask, are you planning on updating the adva module to work in Drupal 10?

πŸ‡³πŸ‡ΏNew Zealand AndyD328 Lyttelton, NZ πŸ‡³πŸ‡Ώ

Hi rgpublic,

Thanks for the patch and thoughts, I agree that suppressing the add to cart message is needed, I've been hoping that it will get into Commerce core and not need anything here.

Have you seen https://www.drupal.org/project/commerce/issues/3317738 ✨ Add an option to disable the add to cart message on a certain order type Fixed what do you think about trying to see if that can get it into commerce core? It looks like a nice discrete change to Commerce could solve this use case.

Kind regards,

Andy

Production build 0.69.0 2024