🇳🇿New Zealand @andyd328

andyd328 → created an issue.

Hi transmitter,

I've uploaded a 3.3 dev version for you to try, and I'm pretty certain it will work for you without any problems.
However, I'm not really happy to make it a full release yet as it does a string substitution on the rendered button markup. Apart from just not liking that approach I haven't decided if represents a bc break ie if it's going to have any effect on sites already using the module that depend on the current behaviour.

I suspect this is more of an issue with how the Belgrade theme adds the classes than this module - it's dependant on the text of the button being 'Add to cart' fairly late in the process. By the time it gets to adding the classes this module has already changed the text and the classes don't get added.

I'll open a support request on Belgrade and see what better ideas they have.

Many thanks Christopher, new release created.

andyd328 → made their first commit to this issue’s fork.

Changed order calc to use getSubtotalPrice instead of getTotalPrice.
Thanks matt.hood!

Thanks for the report Matt.

It's working exactly how I expect here. When I have a min of $20 and a max of $150 it uses the given % inside that range and the appropriate max/min outside it.
Maybe there is a difference in the way taxes are set up or displayed, or something in one of our set ups that's affecting the output?

If you'd like to upload a patch or create a fork I'm happy to have a look and see what the differences are.

Found one at https://wiki.lspace.org/File:ClacksTower181.jpg and made it square with some AI help. But it's well over the recommended 10k

Many thanks Adam!

That would def make sense.
Unfortunately, I'm no graphic artist I didn't come across a free one anywhere, if you have something in mind please upload.

I see the Wp plugin uses a stamp - https://wordpress.org/plugins/gnu-terry-pratchett/

https://www.deviantart.com/haniemohd/art/The-Grim-Squeaker-55587156

https://commons.wikimedia.org/wiki/File:The_Luggage,_from_the_Discworld_...

andyd328 → created an issue.

Thanks for those pointers Alberto, I've never needed to access the releases/versions that way before.

I've moved this back to the ownership queue as, while I can manage releases, we are not in a position to edit the module page or add other maintainers as and when needed.
As Gareth has said, we'd like to keep this module alive and we really need full ownership to be able to do that over time. Is there a reason we/I shouldn't have ownership at this point?

Kristen Pol → credited AndyD328 → .

AndyD328 → created an issue.

Hi Shawn,

In the text at the top:

Drupal module for OAuth2 clients, compatible with Drupal 7, Drupal 9, and Drupal 10. See the documentation guide for the appropriate version for details about implementation.

Drupal 7: 7.x-2.0 ===> this link goes to the relevant docs and is fine
Drupal 9.4+ & Drupal 10 (PHP 8.1): 4.1.x ===> this link goes to the releases page rather than the doc page for that version

It's not a big deal as the docs can be found easily enough but it seemed like it would make it less steps for users.

Cheers,

Andy

AndyD328 → created an issue.

AndyD328 → created an issue.

Thanks Matt, released.

Thanks for the issue & patch, that was a bit of a wtf I left in the code.

I'll put this into a dev release and then into a new release in a few days if there's no issues. I made a change to the rate name setting in the contruction as otherwise the display name was always deftult. Also tidied up a messy if{} in isConfigured - my original mess, not yours.

Please test if you have a chance and let me know. Thanks!

Thanks for the report & patch Dylan. I think my decision to use the default variation bundle is broken now that https://www.drupal.org/project/commerce/issues/3089040 ✨ Single product with multiple variation types Fixed is in core.

I've made a change to get the bundle of the variation being presented for purchase. It's a bit convoluted so if you can test it and let me know if you see a better route that would be awesome.

Hi,

The RC11 release is working well on a live site.

Thanks!

Thanks for posting the link & workaround, very much appreciated!

AndyD328 → created an issue.

The patch work for me. Many thanks auth.

Changing to major as it really is important to pick up custom patterns, borderline critical as it breaks the parts of a site without this patch.

Resolved elsewhere

I think I need the Edit permission too as that's where the Releases tab lives. I tried going direct to https://www.drupal.org/node/2454419/edit/releases → and I get a 403.

Many thanks Adam. I've got a new tag sitting there with the updates from Gareth in it but I don't have permissions to create new releases. Can you add the 'Administer Releases' permission for me or add the 9.1.0 release to the module?

Many thanks!

And thanks to Gareth for making & testing the patch, it went in & worked without any issues.

Hi Goran,

Thanks for your reply. If there's an issue with the permissions we can probably get that sorted with the d.o team,

Cheers,

Andy

Email sent to Adam through d.o contact form

AndyD328 → created an issue.

I have contact gnikolovski through the d.o contact form as he is the last active maintainer.

AndyD328 → created an issue.

AndyD328 → created an issue.

Awesome, thanks Julian!

AndyD328 → made their first commit to this issue’s fork.

I also had this and am also not sure if it is related.

It turned out that there was a second container hanging around in the config from an upgrade from v1.x
We uninstalled and re-installed so that the old container config was removed and it now appears to be working as expected.

Hi Adam,

I just wanted to ask if you were planning on a D10 release for this module? It's not exactly a project blocker, but it would be nice to have :-)

Thanks!

AndyD328 → created an issue.

I just ran into this on upgrading to 1.3.0-rc1 from 1.2.1 as well but don't have anything to add to the

It seems from the above that we can either have the correct email template or have multiple BCC addresses, but not currently both. Is that correct?

AndyD328 → created an issue.

Just following up to see if there's been any movement - this is one of my D10 blockers :-) Thanks!

AndyD328 → created an issue.

Not moving 3.1 to D10

Just following up if there will be a D10 release for this module? Many thanks!

AndyD328 → created an issue.

Patch is working here. Thanks!

Closing this as 3317738 has now been committed to commerce core. Thanks everyone!

This is addressed in #3253200

AndyD328 → created an issue.

Many thanks Richard, I appreciate you taking the time to roll a new dev release.

I tried pulling it in with composer and it got rejected - the dev release doesn't have the updates for 10 in it, but I was able to pull down the git repo, which does have it in. It then installed fine and the Anonymous Access provider on Nodes is working well. I haven't tried the Media provider.

Hi, I would like to ask, are you planning on updating the adva module to work in Drupal 10?

Hi rgpublic,

Thanks for the patch and thoughts, I agree that suppressing the add to cart message is needed, I've been hoping that it will get into Commerce core and not need anything here.

Have you seen https://www.drupal.org/project/commerce/issues/3317738 ✨ Add an option to disable the add to cart message on a certain order type Fixed what do you think about trying to see if that can get it into commerce core? It looks like a nice discrete change to Commerce could solve this use case.

Kind regards,

Andy