πŸ‡ΊπŸ‡ΈUnited States @peachez

Account created on 11 July 2012, almost 12 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States peachez

Here is a patch against 8.x-2.x-dev

πŸ‡ΊπŸ‡ΈUnited States peachez

Here is a patch for BEF 6.0.5 specifically, using the patch from #88. This one accounts for the difference between versions 6.0.5 and 6.0.x with the construct method having the "){" on the same line in 6.0.5 which prevented #88 from applying.
I wasnt sure how to create a MR against a tag (Im probably missing something super simple) but if its possible, please message me and Ill update this to an MR.

πŸ‡ΊπŸ‡ΈUnited States peachez

Tested #88 on D10.2.6 and it fails. Checked out the MR and only difference I can see is that the "){" of the construct method are on the same line in the source code and on a new line in the MR. When applied, the error is thrown as it could not apply and the $request argument doesnt get put in the argument list of the construct() method.
Im not sure if I can make edits to MRs here (they are a bit new for me in Drupal issues) otherwise I would suggest an edit. Hope this helps

πŸ‡ΊπŸ‡ΈUnited States peachez

Rerolling jmdeleon #18 patch for Drupal 10.2.5

πŸ‡ΊπŸ‡ΈUnited States peachez

Update to gin 8.x-3.0-rc10 and needed to re-roll this patch

πŸ‡ΊπŸ‡ΈUnited States peachez

Not sure about this dude at 116 and his spelling errors ;)

In all seriousness, thank you to @lobodacyril for the heads up.
Here is the corrected patch

πŸ‡ΊπŸ‡ΈUnited States peachez

Sorry for the many comments, seems Im having an off couple of days.
This patch modifies #3 to remove the check for port key which is already being checked inside the conditional. This is throwing an unnecessary log error as it is in #3.

πŸ‡ΊπŸ‡ΈUnited States peachez

Update #2 to include check on image url link render array

πŸ‡ΊπŸ‡ΈUnited States peachez

Rerolled #5 but excluded an unused var in Rss.php

πŸ‡ΊπŸ‡ΈUnited States peachez

This is a backport to 2.2.x of the related issue https://www.drupal.org/project/group/issues/3398778 πŸ› Unknown column group_relationship_field_data.tid in 'on clause Needs review in 3.x.

πŸ‡ΊπŸ‡ΈUnited States peachez

Rerolled for addtoany v2.0.x, D10.2.2

πŸ‡ΊπŸ‡ΈUnited States peachez

Rerolled for group v2

πŸ‡ΊπŸ‡ΈUnited States peachez

Thank you for the heads up @DamianMcKenna. Im new to submitting code to drupal.org and inadvertently made a rookie mistake. I will be sure to update this moving forward.

πŸ‡ΊπŸ‡ΈUnited States peachez

peachez β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States peachez

Disregard #4, that was a practice comment :P

πŸ‡ΊπŸ‡ΈUnited States peachez

Updated with FieldList::__construct method documentation to match arguments

πŸ‡ΊπŸ‡ΈUnited States peachez

Patch file added

Production build 0.69.0 2024