Rerolled patch #6 into an MR above.
First time doing it so please let me know if I missed something. Noticed a couple tests failed but marked as allowed to fail.
peachez → created an issue.
Just noting here this patch seems to be in 8.x-3.0-rc11 → but was not mentioned in the bug fixes.
Hey Rajan,
Looks good to me. Thank you
Here is a patch against 8.x-2.x-dev
Here is a patch for BEF 6.0.5 specifically, using the patch from #88. This one accounts for the difference between versions 6.0.5 and 6.0.x with the construct method having the "){" on the same line in 6.0.5 which prevented #88 from applying.
I wasnt sure how to create a MR against a tag (Im probably missing something super simple) but if its possible, please message me and Ill update this to an MR.
Tested #88 on D10.2.6 and it fails. Checked out the MR and only difference I can see is that the "){" of the construct method are on the same line in the source code and on a new line in the MR. When applied, the error is thrown as it could not apply and the $request argument doesnt get put in the argument list of the construct() method.
Im not sure if I can make edits to MRs here (they are a bit new for me in Drupal issues) otherwise I would suggest an edit. Hope this helps
Rerolling jmdeleon #18 patch for Drupal 10.2.5
Update to gin 8.x-3.0-rc10 and needed to re-roll this patch
3rd times the charm?
Not sure about this dude at 116 and his spelling errors ;)
In all seriousness, thank you to @lobodacyril for the heads up.
Here is the corrected patch
Ported 2894747-10.1.x-MR5595-c96a7b79.diff for Drupal 10.2.3
Sorry for the many comments, seems Im having an off couple of days.
This patch modifies #3 to remove the check for port key which is already being checked inside the conditional. This is throwing an unnecessary log error as it is in #3.
Update #2 to include check on image url link render array
Rerolled #5 but excluded an unused var in Rss.php
peachez → created an issue.
This is a backport to 2.2.x of the related issue https://www.drupal.org/project/group/issues/3398778 🐛 Unknown column group_relationship_field_data.tid in 'on clause Needs review in 3.x.
Rerolled for addtoany v2.0.x, D10.2.2
Reroll for D10.2
peachez → created an issue.
Rerolled for group v2
Here a a patch file for the updated $form array
peachez → created an issue.
Thank you for the heads up @DamianMcKenna. Im new to submitting code to drupal.org and inadvertently made a rookie mistake. I will be sure to update this moving forward.
Rerolled for 9.5.11
Disregard #4, that was a practice comment :P
Updated with FieldList::__construct method documentation to match arguments
Patch file added
Here is a patch file for it