- Issue created by @nyanmar
- last update
over 1 year ago Patch Failed to Apply - ๐ฎ๐ณIndia Shreya_98
Shreya_th โ made their first commit to this issueโs fork.
- @shreya_th opened merge request.
- ๐ฎ๐ณIndia Shreya_98
Hi @saschaeggi ,
I have created MR for Undefined array key "breadcrumb" .Kindly review the changes and also
i have observed that the PHPCS in the pipeline are indicating failure so after that i ran a command "$ ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ../moduleslist/gin/"
to check phpcs issues and there we found a lots of issues within this theme .
So i think we have to raise separate tickets for this code standard issues .Thank you
- ๐จ๐ญSwitzerland saschaeggi Zurich
@Shreya_th
to check phpcs issues and there we found a lots of issues within this theme . So i think we have to raise separate tickets for this code standard issues .
If you check the pipelines for this project you'll notice that there is currently only one phpcs notice and not as you report a lot of errors. See https://git.drupalcode.org/project/gin/-/pipelines
But also note that we ignore phpcs for CSS files in this project as we generate them differently to core.
- Status changed to Needs review
about 1 year ago 9:48am 22 September 2023 - Status changed to Needs work
about 1 year ago 12:58pm 25 September 2023 - ๐จ๐ญSwitzerland saschaeggi Zurich
@Shreya_th can you please have a look at the failing pipeline? https://git.drupalcode.org/project/gin/-/jobs/113653
There is a phpcs error.
Thank you!
- Assigned to Shreya_98
- ๐ฎ๐ณIndia Shreya_98
Hi @saschaeggi,
I'm working on phpcs error issues . - Status changed to Closed: outdated
11 months ago 8:36am 10 January 2024 - ๐จ๐ญSwitzerland saschaeggi Zurich
Closing of lack of activity. Feel free to reopen if the problem persists.
- ๐บ๐ธUnited States peachez
Update to gin 8.x-3.0-rc10 and needed to re-roll this patch
- ๐บ๐ธUnited States peachez
Just noting here this patch seems to be in 8.x-3.0-rc11 โ but was not mentioned in the bug fixes.