🇨🇦Canada @web247

Good Stuff !!

The issue is that many of the tests that are failing are the ones that translate the block labels, for example in the file tests/src/FunctionalJavascript/TranslationTest.php after line 115:

    // Update the translations block label.
    $this->drupalGet('it/node/1/layout');
    $this->assertNonTranslationActionsRemoved();
    $this->updateBlockTranslation('.block-system-powered-by-block', 'untranslated label', 'label updated in translation', 'label in translation'); */

    /* TOFIX:$assert_session->buttonExists('Save layout');
    $page->pressButton('Save layout');
    $assert_session->addressEquals('it/node/1');
    $assert_session->pageTextContains('label updated in translation');
    $assert_session->pageTextNotContains('label in translation');

so basically the module is not working at all or some patches need to be applied before fixing the tests.

I'll go for forking a light version of this.

@danrod's changes for the layout_builder_st were rejected, so we are in the same position as we are in the first place, is there a similar module we can use?

Or perhaps creating a new one with less features but enough for what we need to release Wxt 6.1.0 D11

https://www.drupal.org/project/layout_builder_st/issues/3497945#comment-... 📌 Make coding standards fixes Active

If there are lots of tests that are failing, it means that this module was poorly written in the first place.

@danrod's changes were rejected, so we are in the same position as we are in the first place, is there a similar module we can use?

Or perhaps creating a new one with less features but enough for what we need to release Wxt 6.1.0 D11

https://www.drupal.org/project/layout_builder_st/issues/3497945#comment-... 📌 Make coding standards fixes Active

If there are lots of tests that are failing, it means that this module was poorly written in the first place.

It's strange, I am getting a different error in my Drupal.11.1.1 instance:

The website encountered an unexpected error. Try again later.

TypeError: key(): Argument #1 ($array) must be of type array, null given in key() (line 424 of modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php).
Drupal\entity_browser\Plugin\Field\FieldWidget\EntityReferenceBrowserWidget::processEntityBrowser()
call_user_func_array() (Line: 1010)
Drupal\Core\Form\FormBuilder->doBuildForm() (Line: 1073)
Drupal\Core\Form\FormBuilder->doBuildForm() (Line: 1073)
Drupal\Core\Form\FormBuilder->doBuildForm() (Line: 1073)
Drupal\Core\Form\FormBuilder->doBuildForm() (Line: 571)
Drupal\Core\Form\FormBuilder->processForm() (Line: 321)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709)
Drupal\Core\DrupalKernel->handle() (Line: 19)

And I don't see anything in the searchs results regarding this issue, I'll try reproducing the issue in other instances.

I tried replicate your issue but I had no luck, but I got another issue when trying to add an image from the Entity Browser:

Did you also see that?

This is what I am seeing in the DBlog table:

Warning: Undefined variable $edit_button_access in Drupal\entity_browser\Plugin\Field\FieldWidget\FileBrowserWidget->displayCurrentSelection() (line 335 of /var/www/html/html/modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/FileBrowserWidget.php)
#0 /var/www/html/html/core/includes/bootstrap.inc(108): _drupal_error_handler_real()
#1 /var/www/html/html/modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/FileBrowserWidget.php(335): _drupal_error_handler()
#2 /var/www/html/html/modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php(415): Drupal\entity_browser\Plugin\Field\FieldWidget\FileBrowserWidget->displayCurrentSelection()
#3 /var/www/html/html/modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/FileBrowserWidget.php(146): Drupal\entity_browser\Plugin\Field\FieldWidget\EntityReferenceBrowserWidget->formElement()
#4 /var/www/html/html/core/lib/Drupal/Core/Field/WidgetBase.php(459): Drupal\entity_browser\Plugin\Field\FieldWidget\FileBrowserWidget->formElement()
#5 /var/www/html/html/core/lib/Drupal/Core/Field/WidgetBase.php(101): Drupal\Core\Field\WidgetBase->formSingleElement()
#6 /var/www/html/html/core/lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php(197): Drupal\Core\Field\WidgetBase->form()
#7 /var/www/html/html/core/lib/Drupal/Core/Entity/ContentEntityForm.php(121): Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm()
#8 /var/www/html/html/core/modules/node/src/NodeForm.php(138): Drupal\Core\Entity\ContentEntityForm->form()
#9 /var/www/html/html/core/lib/Drupal/Core/Entity/EntityForm.php(107): Drupal\node\NodeForm->form()
#10 [internal function]: Drupal\Core\Entity\EntityForm->buildForm()
#11 /var/www/html/html/core/lib/Drupal/Core/Form/FormBuilder.php(528): call_user_func_array()
#12 /var/www/html/html/core/lib/Drupal/Core/Form/FormBuilder.php(370): Drupal\Core\Form\FormBuilder->retrieveForm()
#13 /var/www/html/html/core/lib/Drupal/Core/Form/FormBuilder.php(625): Drupal\Core\Form\FormBuilder->rebuildForm()
#14 /var/www/html/html/core/lib/Drupal/Core/Form/FormBuilder.php(321): Drupal\Core\Form\FormBuilder->processForm()
#15 /var/www/html/html/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm()
#16 /var/www/html/html/core/modules/layout_builder/src/Controller/LayoutBuilderHtmlEntityFormController.php(39): Drupal\Core\Controller\FormController->getContentResult()
#17 [internal function]: Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult()
#18 /var/www/html/html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#19 /var/www/html/html/core/lib/Drupal/Core/Render/Renderer.php(593): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#20 /var/www/html/html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext()
#21 /var/www/html/html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#22 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(183): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#23 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#24 /var/www/html/html/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Symfony\Component\HttpKernel\HttpKernel->handle()
#25 /var/www/html/html/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#26 /var/www/html/html/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#27 /var/www/html/html/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle()
#28 /var/www/html/html/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\big_pipe\StackMiddleware\ContentLength->handle()
#29 /var/www/html/html/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#30 /var/www/html/html/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#31 /var/www/html/html/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle()
#32 /var/www/html/html/core/lib/Drupal/Core/DrupalKernel.php(709): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
#33 /var/www/html/html/index.php(19): Drupal\Core\DrupalKernel->handle()
#34 {main}

We will look into the 4 remaining test issues for the layout_builder_st today. @danrod

We will look into the 4 remaining test issues for the layout_builder_st today. @danrod

Yup, we are the OPTASY team :)

ok, we are on that now.

I can look into the phpstan issues for toc_api and push for a tagged release, if that helps.

Attached a patch for review.

web247 → created an issue.

Good Morning @smulvih2 yes, sorry, forgot to attach the latest patches !

Please have a look if you have some time, meanwhile I'll create patches for the 6.1.x while we figure it out the hidden fields issue.

Finally I was able to work the functionality in the 5.4.x but I had a few issues

- I added the config settings in these files:

modules/custom/wxt_ext/wxt_ext_page/config/optional/core.entity_form_display.node.page.default.yml
modules/custom/wxt_ext/wxt_ext_page/config/optional/core.entity_view_display.node.page.default.yml

But for some reason some of the fields were hidden by default, and the widget that holds the byline options didn't work at all, so I got rid of it

- I tried adding some workaround PHP code at modules/custom/wxt_ext/wxt_ext_page/wxt_ext_page.install in a new function, wxt_ext_page_update_8501 but the function just neved executed, is there an issue with the functions at this install file? They don't seem to be working

- As a last resort, I had to add my workaround code at

modules/custom/wxt_ext/wxt_ext_page/wxt_ext_page.module

, in the function wxt_ext_page_form_alter, but this is far from a good solution.

Here's some screens of the byline functionality and page rendering:

I'll create patches for the 6.1.x branch for now, I'm open to rewrite the patches if the workaround solution doesn't satisfy anyone

web247 → created an issue.

I have the patches for the wxt54x branch, they add the fields and the needed changes, but for some reason it doesn't set up the page content type correctly, because it sets the fields as "Disabled" in the form display even though it is clear in the patches that they should be displayed, I don't know how to fix this, so I'll pass on this issue, any takers?

This is how it looks after the patch:

The config in the patch has a different configuration:

diff --git a/modules/custom/wxt_ext/wxt_ext_page/config/optional/core.entity_form_display.node.page.default.yml b/modules/custom/wxt_ext/wxt_ext_page/config/optional/core.entity_form_display.node.page.default.yml
index 14a99018..ddb9f541 100644
--- a/modules/custom/wxt_ext/wxt_ext_page/config/optional/core.entity_form_display.node.page.default.yml
+++ b/modules/custom/wxt_ext/wxt_ext_page/config/optional/core.entity_form_display.node.page.default.yml
@@ -1,18 +1,40 @@
+uuid: 7931bce3-8cfd-44b0-932a-309a4770d785
 langcode: en
 status: true
 dependencies:
   config:
     - field.field.node.page.body
-    - field.field.node.page.layout_builder__layout
-    - field.field.node.page.layout_builder__translation
-    - field.field.node.page.layout_selection
+    - field.field.node.page.comment
+    - field.field.node.page.field_byline
     - field.field.node.page.field_lead_title
+    - field.field.node.page.field_meta_tags
     - node.type.page
+    - workflows.workflow.editorial
   module:
     - content_moderation
+    - field_group
     - metatag
     - path
     - text
+third_party_settings:
+  field_group:
+    group_byline:
+      children:
+        - field_byline
+      label: Byline
+      region: content
+      parent_name: ''
+      weight: 14
+      format_type: details_sidebar
+      format_settings:
+        classes: ''
+        show_empty_fields: false
+        id: ''
+        label_as_html: false
+        open: false
+        description: ''
+        required_fields: true
+        weight: 0
 id: node.page.default
 targetEntityType: node
 bundle: page
@@ -20,95 +42,109 @@ mode: default
 content:
   body:
     type: text_textarea_with_summary
-    weight: 6
+    weight: 2
+    region: content
     settings:
       rows: 9
       summary_rows: 3
       placeholder: ''
+      show_summary: false
     third_party_settings: {  }
-    region: content
   created:
     type: datetime_timestamp
-    weight: 2
+    weight: 5
+    region: content
     settings: {  }
     third_party_settings: {  }
+  field_byline:
+    type: options_select
+    weight: 16
     region: content
+    settings: {  }
+    third_party_settings: {  }
+  field_lead_title:
+    type: string_textfield
+    weight: 1
+    region: content
+    settings:
+      size: 60
+      placeholder: ''
+    third_party_settings: {  }
+  field_meta_tags:
+    type: metatag_firehose
+    weight: 13
+    region: content
+    settings:
+      sidebar: true
+      use_details: true
+    third_party_settings: {  }
   langcode:
     type: language_select
-    weight: 2
+    weight: 3
     region: content
     settings:
       include_locked: true
     third_party_settings: {  }
-  layout_selection:
-    type: options_select
-    region: content
-    weight: 102
-    settings: {  }
-    third_party_settings: {  }
   moderation_state:
     type: moderation_state_default
-    weight: 100
-    settings: {  }
+    weight: 11
     region: content
+    settings: {  }
     third_party_settings: {  }
   path:
     type: path
-    weight: 5
+    weight: 10
+    region: content
     settings: {  }
     third_party_settings: {  }
-    region: content
   promote:
     type: boolean_checkbox
+    weight: 8
+    region: content
     settings:
       display_label: true
-    weight: 3
     third_party_settings: {  }
+  simple_sitemap:
+    weight: 6
     region: content
+    settings: {  }
+    third_party_settings: {  }
   status:
     type: boolean_checkbox
-    weight: 10
+    weight: 12
+    region: content
     settings:
       display_label: true
     third_party_settings: {  }
-    region: content
   sticky:
     type: boolean_checkbox
+    weight: 9
+    region: content
     settings:
       display_label: true
-    weight: 4
     third_party_settings: {  }
-    region: content
   title:
     type: string_textfield
     weight: 0
+    region: content
     settings:
       size: 60
       placeholder: ''
     third_party_settings: {  }
-    region: content
-  field_lead_title:
-      type: string_textfield
-      weight: 1
-      region: content
-      settings:
-        size: 60
-        placeholder: ''
-      third_party_settings: {  }
   translation:
-    weight: 10
+    weight: 7
     region: content
     settings: {  }
     third_party_settings: {  }
   uid:
     type: entity_reference_autocomplete
-    weight: 1
+    weight: 4
+    region: content
     settings:
       match_operator: CONTAINS
+      match_limit: 10
       size: 60
       placeholder: ''
     third_party_settings: {  }
-    region: content
 hidden:
-  layout_builder__layout: true
-  layout_builder__translation: true
+  comment: true

Has anyone encountered the same issue? I'd love a second opinion on this

Oh, I see what the problem is, in your phpunit.xml file, make sure the SIMPLETEST_BASE_URL setting points to http://localhost and NOT httpS, after that I was able to pass the tests with my patch:

@joseph.olstad I mean, I was able to apply the patch with no issues:

Yeah, I am seeing that error now, didn't get that error before. Strange.

New patch worked fine for me.

Forgot to add the patch !

Attached a patch file to remove the FS patch in the wxt composer.json file

web247 → created an issue.

I created a patch that basically supresses the error when running the unit tests, but it doesn't actually fix the countries schema not being loaded, I'll look on that later today, I might open a different issue page for that.

I just ran the phpunit tests in the wxt profile (I am using 6.1.x), I came across this error (I saw this error on 5.4.x as well):

I do see the schema file in the codebase:

./html/profiles/wxt/modules/custom/wxt_core/config/install/wxt_core.settings.countries.yml

But perhaps it's not being created during the installation time? I had a look at the ./html/profiles/wxt/modules/custom/wxt_core/wxt_core.install and I can see the function wxt_core_update_8502() that loads the schema, perhaps this one is not being executed anymore during the installation time (that's my wild guess):

**
 * Issue #3399929: Change wxt_core countries config namespace.
 */
function wxt_core_update_8502() {
  $legacy = 'wxt_core_countries.settings';
  $updated = 'wxt_core.settings.countries';
  $config_factory = \Drupal::configFactory();
  $module_handler = \Drupal::service('module_handler');
  $module_path = $module_handler->getModule('wxt_core')->getPath();
  $path = DRUPAL_ROOT . '/' . $module_path . '/config/install/' . $updated . '.yml';
  $hasUpdated = $config_factory->get($legacy)->isNew();
  if ($hasUpdated) {
    $country_data = $config_factory->getEditable($legacy);
    $config = $config_factory->getEditable($updated);
    if (!is_array($country_data)) {
      // Update hook 8501 wasn't run correctly for some reason, or the yml was
      // deleted.
      wxt_core_update_8501();
      return;
    }
    $config->setData($country_data);
    $config->save();
    // Delete old data.
    $country_data->delete();
  }
  else {
    $country_data = Yaml::parse(\file_get_contents($path));
    $config = $config_factory->getEditable($updated);
    $config->setData($country_data);
    $config->save();
  }
}

Thanks @joseph.olstad , I'm just wondering if these "deprecated class constants" warning that I see when running upgrade_status against the wxt installation are worth to fix it at this point, I can provide a patch for this, but not sure if it's worth the time given that core version is 11.1.2 and D12 is not near at the corner yet:

Cool ! don't forget the credits please :)

Just bumping into this, will this be incorporated in the 5.4.x - 6.1.x branch? One of my clients could benefit from it.

Please let us know and we can rewrite the patches to make it work with the latest branches.

web247 → created an issue.

I see that the "Search website" is already localized and can be translated from the config settings (/admin/config/regional/translate):

Shall we introduce a rule or a config setting to do the translation during the installation time?

web247 → created an issue.

Ok guys, can anybody point me how to get the 6.1.x-dev release? This doesn't seem to work:

composer create-project drupalwxt/site-wxt:6.1.x-dev wxt61x --no-interaction

I took the liberty to create a patch for the 5.4.x-dev and worked great to us:

Attached the patch as well

Yes, I looked on this, the footnotes in my WxT 5.6.x-dev instance, doesn't look great:

Hello @alok_singh Do you have the steps to replicate the issue? Using 5.4.x-dev and I didn't find a way to trigger this WSOD

Thanks @smulvih , I'll move it to "Needs Review" for now

Hello @alok_singh how did you run into this? I'm using 5.4-x-dev and not sure how to replicate this.

web247 → created an issue.

Looks like this is in almost alpha state now, I'll do some tests myself (I'll install the 6.1.x-dev branch)

web247 → created an issue.

I'd work on this one, since I am the same issues in my ol wxt 5.3 instance

web247 → created an issue.

web247 → created an issue.

looks good

looks good

great!

web247 → made their first commit to this issue’s fork.

web247 → created an issue.

web247 → created an issue.

web247 → created an issue.

web247 → created an issue.

web247 → created an issue.

web247 → created an issue.

Good work! seems like everything is in line here.

even on a different content type, please check your permission setup, such as this:

user has to also have access to "Access Bidding Form"

yes, these are around un-released lines of work.

Tested, works as expected.

This looks O.K, I see the new ARIA attributes now:

Works ok to me:

I did some tests with axe-core myself and I didn't see this issue anymore, I just got an issue not related with the widget

Ensures elements with ARIA roles have all required ARIA attributes

more informationLink opens in a new window
Element Location:
.col-sm-12
<div class="col-sm-12" role="heading">
              <div class="region region-header">
    <div data-drupal-messages-fallback="" class="hidden"></div>
    <h1 class="page-header" id="fluid-id-6u6rafqq-322">Welcome!</h1>


  </div>

          </div>

Tested, I can see the JSON key being uploaded into the private directory.

Good Morning, I tested this, I could import some of the events that I had from my google calendar, can be moved this to RTBC+1

web247 → made their first commit to this issue’s fork.

Tested this on a D10.1 instance, works perfect, thanks !

Fixed in the latest release: https://www.drupal.org/project/estore/releases/8.x-1.15 →

Thank you.

The new release fixes this issue: https://www.drupal.org/project/estore/releases/8.x-1.15 →

Thanks a lot for everyone involved.

web247 → made their first commit to this issue’s fork.