Remove old fontawesome patch

Created on 23 February 2025, about 1 month ago

Problem/Motivation

I was looking around at the list of applied patches in the composer.json file and this one caught my attention:

            "drupal/fontawesome": {
                "3071758 - Fix multiple icons issue":
                "https://git.drupalcode.org/project/fontawesome/-/merge_requests/4.diff",
            }

That is a patch for the issue: https://www.drupal.org/project/fontawesome/issues/3071758

Which fixes a problem for the version 8.x-2.14.

But WxT uses the ^3 version now:

"drupal/fontawesome": "^3.0"

I reversed the patch in question ("https://git.drupalcode.org/project/fontawesome/-/merge_requests/4.diff"), and

$ patch -p1 -R < 4.patch 
patching file js/plugins/drupalfontawesome/plugin.es6.js
patching file js/plugins/drupalfontawesome/plugin.js

And I inserted two Fontawesome icons in a row to reproduce the issue mentioned in the issue page and I was able to do it with no issues:


Steps to reproduce

Install WxT 6.1.x, comment out or remove the lines regarding that patch (276, 277), then follow the issue the steps to replicate the issue (I used the Rich Text text editor): https://www.drupal.org/project/fontawesome/issues/3071758 and you should be able to add the icons with no problem

Proposed resolution

Remaining tasks

User interface changes

🐛 Bug report
Status

Active

Version

6.1

Component

Code

Created by

🇨🇦Canada web247 Toronto

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024