🇸🇪Sweden @sl27257

Thanks for your patches! Will try to test them and then commit them.

/Thomas

Can you provide a normal patch based on the -dev, please?

I am sorry, but I have no idea how to handle this so called "Issue fork".

Hmmm,

this was a loooong time ago... I need to figure out if I can manage to recreate this...

/Thomas

Hi,
I am sorry, I used this in an event-site which now is removed. So unfortunately I have no easy way to write test code (and check that it behaves correctly for this case.)

/Thomas

Stepping status

Now with dependency information

A fix for the problem.

sl27257 → created an issue.

sl27257 → created an issue.

That was a polite question!!!

If you check my profile you will see that I am not either affiliated with Drupal. I am handling another module on my "spare time" so I know exactly what you are talking about!

Unfortunately we are only something like less than 5% nowadays that are NOT working on Drupal as a PAID job. And given the extensive updates from D7 to D8 and now all the incompatible changes between the different D9, D10, D11 we have seen causing a lot of problem for us doing things on our spare time!

But if I get answers like yours I will mark my module as unsupported. It is not so funny to get comments like yours when you are doing something for fun and still being somewhat proud that you have achieved over the years!

That said!

So when can we expect to see a solution? IMHO this should not be marked "Fixed" until we Rules-users can upgrade to D10.3.

/Thomas

Hi,

thanks for the pointer I will mark this as a duplicate of 💬 Rules requires earlier version of Typed_data not compatible with Drupal 10.3 Fixed

Anyhow, this is on a live site so because of that I will not try a -dev as there could be other problems.

/Thomas

sl27257 → created an issue.

Hi,

I think (first analysis!) that you currently can add a field to every flag_list someone creates. That can of course be done, but it is not what you want. You want additional fields to be copied from your template flag. And that is currently not happening.

Can you check, please, if you manually add a field like "Count" to a flag_list that someone has created will solve your problem? If so I will check how to fix that the extra field are not copied from the template flag.

BR

/Thomas

Hi,

thank you for your support request!

I think that I understand what you are after. However I have no quick solution, but only some ideas on how to solve it. What comes to my mind is to add some extra fields somewhere. Let me try to play with that idea!

BR

/Thomas

This is an interesting bug. I wonder how many other modules that uses AJAX that will pass your test. If you use the path as an argument to the token they will fail on this as it is not handled in core in a good way I would say.

But for the flag_lists I think it will be OK now.

I now know what is causing this.

Sometimes the token is calculated with the language selector included and sometimes without. In the flag_lists module it calculated with the selector but in the flag module, which I inherit a lot of functionality from, it is done without.

So the question is which fix to go for. I need to check the documentation for which is the proper way to do it...

Changing status

Hi,

I am sorry, but as pointed out in #5 🐛 Deprecated function: mb_strtolower(): Passing null to parameter Active above, this is NOT the problem here.

Now I have managed to recreate the error. I must say that I have never on any of my sites run the site in a mode / way so that this error will occur.

/Thomas

The problem here is exactly this:

🐛 Querying with NULL values results in warning mb_strtolower(): Passing null to parameter is deprecated Needs work

But as stated in #25 🐛 Querying with NULL values results in warning mb_strtolower(): Passing null to parameter is deprecated Needs work this a problem in core which can be caused by a contributed module. So I will not mark this as a duplicate yet. Instead this will be kept open so that it can be fixed in the flag_lists if possible.

Thanks for the info.

I started trying to find the bug yesterday but bumped into the following problem.

🐛 Deprecated function: mb_strtolower(): Passing null to parameter Active

In worst case I need to patch the core to temporary get rid of it. Anyhow another question:

/fr/node/1

Is the /fr the language selector (French) or is that a sub directory?

/Thomas

Hi,

I am sorry but that is not the problem here :(

/Thomas

sl27257 → created an issue.

Hi,

thank you for your report!

Do you have any information on when this worked. I.e. did this work on D9 for instance? The reason is that I am trying to figure out if there is a change in Drupal or if this is an bug that has not been found yet?

But anyhow I have seen other modules where this has been an issue, so I guess it is only a matter of finding the culprit...

/Thomas

sl27257 → created an issue.

After studying the two diffs above I guessed that this could have to do with the cache.

As I couldn't get Drupal to work I tried to clear the case in the database directly.

To find the tables:

show tables like '%cache%';

Then to truncate the tables found with the command above (except the cachetags):

truncate <table name from list above>;

And voila, it worked!

But there still were some dependency problem to like that Drupal only went to 10.0.x. So I had to step to Drupal 10.1.x in a separate step.

Hi,

I get roughly the same response related to the escape filter. Did you find any solution for this? (I have this problems one one of my sites. I have two more which also crashes with the original Render doCallback().)

BTW: I have removed the original theme on the site which was a sub theme of Bootstrap. Now it us using olivero.

Hi,

thanks for the report!

I am a sort of aware of this problem. It is mentioned in the release note for flag_lists 4.0.0-rc3 where it is listed as a dependency to the flag module. So if I understand this correctly it will break sooner or later and require a fix in the flag module.

But that said, your patch is is a great way to get away from the flag module dependency!

Thanks!

Thank you for your patch!

Let me try it before I push it to the dev!

Hi,

there are other problems with D10 for the flag lists as well, unfortunately. It is a dependency to the flag module. I have mentioned in the release note for -rc3.

It might be time to check the flag module again to see if it is fixed. Will do!

+1 for patch #8