- πΊπΈUnited States tr Cascadia
I moved this to the current branch of this module, and I re-rolled the patch from #8 and put it into a MR so that it can be tested on GitLab CI.
None of the Wbform-specific code in this module is currently being tested at all. It is not maintainable. If we are going to make exceptions for Webform fields then we really really really need test cases for those exceptions. Can you write a simple test for this, hopefully without requiring the test to have a full install of Webform?
- πΈπͺSweden sl27257 Stockholm
Hi,
I am sorry, I used this in an event-site which now is removed. So unfortunately I have no easy way to write test code (and check that it behaves correctly for this case.)/Thomas
- Status changed to Needs work
about 2 months ago 7:51am 19 February 2025 - π©πͺGermany sense-design MΓΌnster
For there is still a bug, because of this error message
> Drupal\views_aggregator\Plugin\views\style\Table::renderNewWebformValue(): Argument #2 ($row_num) must be of type int, null givenchanging this
protected function renderNewWebformValue(FieldHandlerInterface $field_handler, int $row_num, mixed $new_values, string $separator)
to this fixes it
protected function renderNewWebformValue(FieldHandlerInterface $field_handler, int|null $row_num, mixed $new_values, string $separator)
- πΊπΈUnited States tr Cascadia
@sense-design: The problem you stated in #14 is not the same as this issue.
Your problem is π TypeError: Drupal\views_aggregator\Plugin\views\style\Table::setCell(): Argument #2 ($row_num) must be of type int, null given Active , and you should read the discussion there and contribute to a solution in that issue.