🇬🇧United Kingdom @danchamp

danchamp → created an issue.

danchamp → created an issue.

danchamp → created an issue.

@joachim This rationalises the checks for $collections and $address in viewSchedule() and returns early if there's any issue.

@joachim This was a hangover from the source module that had an image for each bin type.

Removing for now, I can imagine there will be demand for that as a future feature.

danchamp → made their first commit to this issue’s fork.

Thanks @joachim.

danchamp → made their first commit to this issue’s fork.

danchamp → made their first commit to this issue’s fork.

danchamp → made their first commit to this issue’s fork.

Nice, thanks @joachim.

danchamp → made their first commit to this issue’s fork.

Thanks, merged.

danchamp → made their first commit to this issue’s fork.

Have you actually got two different bin types with the same colour?!

If we need to support that, we may need to decouple bin types, colours, and CSS icon shapes - at the moment blue is always a triangle, and having two collection lines for different bins with the same colour and icon is not good.

Maybe the option to map bin keys to colours and icons in config, then we can adjust CSS classes accordingly if it's set?

Or an easier route, we add the bin type as a class to the collection item alongside colour in localgov-waste-collection-collection-item.html.twig

This will at least provide a hook for custom CSS to override the colour and accommodate types with the same colour, which sounds like an edge case.

Thanks @joachim, fixed and merged.

Thanks @joachim, merged.

danchamp → made their first commit to this issue’s fork.

@joachim I'd welcome a review of this please, not entirely sure what I've got is the best approach.

I was there.

danchamp → made their first commit to this issue’s fork.

danchamp → created an issue. See original summary → .

danchamp → created an issue.

danchamp → created an issue.

Thanks @joachim, default branch is now 1.x

danchamp → made their first commit to this issue’s fork.

@joachim This works beautifully, thanks.

danchamp → made their first commit to this issue’s fork.

@joachim. I think an empty array is fine? That's the message we ended up with after discussion with the initial local authority this was developed for, and was accepted by later authorities.

It does accurately reflect the situation, and gives the user an explanation and way forward.

Happy to hear alternative views though.

Thanks @joachim, reviewed and tested, looks good to me.

danchamp → made their first commit to this issue’s fork.

danchamp → made their first commit to this issue’s fork.

danchamp → created an issue.

danchamp → made their first commit to this issue’s fork.

danchamp → made their first commit to this issue’s fork.

Thanks @joachim, extended to sub-modules.

danchamp → made their first commit to this issue’s fork.

danchamp → made their first commit to this issue’s fork.

Thanks @joachim @ajinkya45

danchamp → made their first commit to this issue’s fork.

@joachim Do you know which version of the Whitespace API is in use for your site? Do you have the API documentation?

The plugin was written for a Council using v11.0, but I know that changes were introduced in v11.1 (such as support for date ranges beyond a single month), and there may be later versions with more breaking changes.

@joachim, thanks, merged.

danchamp → made their first commit to this issue’s fork.

Thanks @joachim, merged.

Thanks @joachim, merged.

@joachim Thanks, fixed.

danchamp → made their first commit to this issue’s fork.

danchamp → made their first commit to this issue’s fork.

Thanks @joachim, merged and closed as fixed.