- Issue created by @joachim
- 🇬🇧United Kingdom joachim
Pushing an attempt at a fix, but outputting an error message when we catch an exception contradicts the error message in twig:
<p class="alert alert-info">No properties found for postcode {{ noresults }}. Please check this is a valid postcode and search again.</p>
as both will show in the case of a Guzzle exception.
Not sure how best to fix this.
- Merge request !6Added catching of Guzzle exceptions and logging to Whitespace data provider... → (Merged) created by joachim
- 🇬🇧United Kingdom joachim
I should move the catching to a helper method, as this should happen further on too.
- 🇬🇧United Kingdom joachim
Added a helper for making SOAP calls, which handles SOAP errors and re-throws them.
- First commit to issue fork.
-
danchamp →
committed 19b5211f on main authored by
joachim →
Issue #3529150 by joachim: Guzzle exceptions in Whitespace provider are...
-
danchamp →
committed 19b5211f on main authored by
joachim →
- 🇬🇧United Kingdom danchamp Angus
Thanks @joachim, reviewed and tested, looks good to me.