- πΊπΈUnited States smustgrave
Eh Iβll take your word. Donβt want to increase LOE for something that seems to make sense I think. And doesnβt break anything.
Going to take a swing
- π¦π²Armenia murz Yerevan, Armenia
It just demonstrates the missing Simpletest environment in the drush command, with no failure. If you need, I can make a separate MR with the failing test.
We can launch something likedrush core-status --field=site-path
and check the output, but faced an issue with Drush about this: https://github.com/drush-ops/drush/issues/6225 - πΊπΈUnited States smustgrave
The linked issue thats show this problem is actually green?
- π¬π§United Kingdom the_g_bomb
Yeah, I did think there would be a reason for using a slimmed-down profile, but then as the a11y tests are testing the user experience rather than specific functions or features, using a controlled environment might not test what users actually experience.
In fact, there is a case that freshly installed Drupal may not have enough things in place to ensure everything is accessible. e.g. the homepage list of articles with pagination.
To be honest, I suspect we may want each profile to have its own set of tests. I would love to see umami_demo and the drupal cms out-of-the-box experience covered by some a11y tests.
Thanks for the feedback, looking forward to seeing how you get on with PHPUnit.
- πΊπΈUnited States kentr Durango, CO
@the_g_bomb
I think it would be a good idea to move the existing Nightwatch tests to either Playwright or PHPUnit as appropriate when they are available. Just keen to get the current tests working as optimally as possible in the meantime.
Agreed. It sounds like phpunit is the first choice based on π Consider dropping Nightwatch in favor of Functional Javascript tests Active .
I've done some work on π Automated A11y tests in PHPUnit Needs work and replicated the current Nightwatch a11y tests, but hit a snag π Automated A11y tests in PHPUnit Needs work .
- πΊπΈUnited States kentr Durango, CO
FYI, there was some concern about using the standard profile when the nightwatch a11y tests were created: #3293469-23: Automated A11y tests in Nightwatch β
- π¬π§United Kingdom the_g_bomb
FYI, I think it would be a good idea to move the existing Nightwatch tests to either Playwright or PHPUnit as appropriate when they are available. Just keen to get the current tests working as optimally as possible in the meantime.
- π¬π§United Kingdom the_g_bomb
FYI, I think it would be a good idea to move the existing Nightwatch tests to either Playwright or PHPUnit as appropriate when they are available. Just keen to get the current tests working as optimally as possible in the meantime.
- π¬π§United Kingdom the_g_bomb
I suspect this should be solved by: β¨ Expand the a11y nightwatch coverage in Core Active
In that PR Standard has been used, and as you suggest more Axe tests fail and as such those tests have had to be skipped for now.