Automate Accessibility Checks for Core

It would be great to get a list of the URLs that are presently being covered by axe. There are some issues sneaking into Core that should have been caught by automated testing.

As with any good CI/CD process, it is important to monitor that list of URLs on a regular basis to ensure that we are using the best sampling that we can.

Phase 1 & 2 in the description identified some key URLs. It is unclear (without digging into the code) which URLs are being tested.

RE #25, I found these test case URLs.

• "/"
• "/admin/content"
• "/admin/structure"
• "/admin/structure/block"
• "/admin/structure/taxonomy/add"
• "/admin/structure/types/add"
• "/node/add/page?destination=/admin/content"
• "/search/node"
• "/user/1/edit" (tested with and without the navigation module
• "/user/login"

In these files:

• a11yTestDefault.js
• a11yTestAdmin.js
• a11yTest.js

I'm wondering if there's an error in the admin tests.

{ name: 'Create Article', path: '/user/1/edit' },

Should perhaps be:

{ name: 'Create Article', path: '/node/add/article?destination=/admin/content' },

There are some issues sneaking into Core that should have been caught by automated testing.

Some of these missed issues may be a result of the limited nightwatch_a11y_testing profile. A bunch of Axe errors appear when I use the modules from the standard profile.

I've been digging into it a little more before I create an issue.

Certainly, that create article path looks wrong.

I created this issue and fixed the path.
🐛 Incorrect path used in a A11y Test Admin Active

I have also created: ✨ Expand the a11y nightwatch coverage in Core Active to pickup the rest of the coverage

Make some custom assertions about the component we're interested in. A dialog appears, has expected markup, focus moves to dialog. And finally run all the general ruleset AGAIN.

I can see also this for:

• Disclosure pattern in general.
• Menus 🌱 [PP1][PLAN] Accessibility review Postponed .

I'd also like to have a policy / coding standard for tests regarding the locating of elements by name, or role & name, when possible.

It's closer to how users interact with the page and would build in a check for the correctness of the name (if the name is incorrect, the element won't be found). Sweeps with Axe will find missing names but won't confirm that they are correct.

It looks like Nightwatch doesn't currently offer a clean solution, but Playwright does. So, maybe after 📌 Consider dropping Nightwatch in favor of Functional Javascript tests Active . Or, we could implement the workaround described in the Nightwatch GitHub issue as a custom Nightwatch command.

Testing for Drupal core now pretty much fully within core itself. (If a custom container is needed, there is https://www.drupal.org/project/drupalci_environments → , although well-supported 3rd-party containers are preferred.) If this can land in a way that contributed projects could take advantage of, there is https://www.drupal.org/project/gitlab_templates →