Contrib.social

Revise image field min/max settings help text form for clarity

Open on Drupal.org →
Created on 7 July 2010, almost 15 years ago
Updated 4 September 2024, 10 months ago

Problem/Motivation

The label and help text for the maximum and minimum resolution settings on image fields could be improved.

Current text

Maximum image resolution

The maximum allowed image size expressed as WIDTH×HEIGHT (e.g. 640×480). Leave blank for no restriction. If a larger image is uploaded, it will be resized to reflect the given width and height. Resizing images on upload will cause the loss of EXIF data in the image.

Minimum image resolution

The minimum allowed image size expressed as WIDTH×HEIGHT (e.g. 640×480). Leave blank for no restriction. If a smaller image is uploaded, it will be rejected.

Steps to reproduce

  1. Install Drupal
  2. Edit the image field on Article content type, or add a new image field to a content type
  3. See the help text for 'Maximum image resolution' and 'Minimum image resolution'

Proposed resolution

Update the help text to:

Maximum image dimensions

The maximum allowed image dimensions as WIDTH×HEIGHT (e.g. 640×480). Leave blank for no restriction. If a larger image is uploaded, it will be resized to the given width and height. Depending on the toolkit in use, resizing images on upload may cause the loss of image metadata.

Minimum image dimensions

The minimum allowed image dimensions as WIDTH×HEIGHT (e.g. 640×480). Leave blank for no restriction. If a smaller image is uploaded, it will be rejected.

Remaining tasks

  1. Agree on the wording change
  2. Write a patch
  3. Review

User interface changes

Before patch:

After patch:
TBC

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

🐛 Bug report
Status

RTBC

Version

11.0 🔥

Component
Image module  →

Last updated 6 days ago

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • @pameeela opened merge request.
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇦🇺Australia pameeela

    Created an MR for this based on the wording I proposed three years ago :)

  • Status changed to RTBC 10 months ago
  • Comment 10 months ago →
    🇺🇸United States smustgrave

    Seems straight forward to me.

  • Comment 9 months ago →
    🇳🇿New Zealand quietone

    I read the IS, comments and the MR. There are no unanswered questions here. Thanks for the updated screenshots and an up to date issue summary.

    The only comment I have is that the new text mentions the 'toolkit' in use. But there is no help text in core for 'toolkit' or how to change it etc. Perhaps a follow is needed for that.

  • Comment 8 months ago →
    🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

    Can we get some justification in the issue summary of why the original text is bad. I don't see an objective explanation. The change will require translators to add a new translation for both of these strings - so we should have a good reason to add this work.

  • Comment 8 months ago →
    🇺🇸United States smustgrave
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024