Pass Search API Server object to AiVdbProvider plugins for more context

a.dmitriiev → changed the visibility of the branch 3521601-pass-search-api to hidden.

MR is in draft and has failing tests, so knocking back to needs work.

So with this MR is ai 1.1.x needed? Wasn't this the cause of that other branch?

Test failure:

Fatal error: Declaration of Drupal\field_validation\Plugin\Validation\Constraint\UlidConstraint::validatedBy() must be compatible with Symfony\Component\Validator\Constraint::validatedBy(): string in /builds/issue/ai-3521601/web/modules/contrib/field_validation/src/Plugin/Validation/Constraint/UlidConstraint.php on line 21

This is not relevant to the MR and moreover it is from another module.

Added some comments to the MR. I still think (per slack) that this should never go to 1.1.x though as getClient() should just get client and not cause side effects. And since 1.1.x has a mechanism to get the server, this is really just temporary throw away code for 1.0.x

I have fixed the issues mentioned in the MR comments.

Regarding "throw away code" I disagree. You mention that there is now a way to get the context, but it is only available for method vectorSearch, how would it be retrieved in any other method of the class if needed?

how would it be retrieved in any other method of the class if needed?

My point isn't that its not necessarily not needed, but that if it is needed elsewhere (is it??), adding a side effect to getClient() does not seem like the right way to do it, so more that this approach is temporary code to solve specific problem in 1.0.x. Have not looked deeply, but maybe some way in AiVdbProviderPluginManager::createInstance() to construct the provider e.g. in AiVdbProviderClientBase...

Can this be reapplied to 1.1.x please?

Moving changes from 1.0.x to 1.1.x in order to move forward this topic.

gxleano → changed the visibility of the branch 3521601-server-context to hidden.

Merged with 1.1.x as well.

Automatically closed - issue fixed for 2 weeks with no activity.