- Issue created by @nicxvan
- 🇺🇸United States dww
Copying some relevant comments from the MR threads...
dww
Looking more closely, this whole method (in
core/modules/pgsql/src/Hook/PgsqlRequirementsHooks.php) is identical tocore/modules/pgsql/src/Requirements/PgsqlRequirements.php. Any harm in this runtime/update Hook instantiating the special install-time class to re-use the code instead of maintaining 2 distinct copies of this?nicxvan
The line of what can be injected is different for install phase. So it feels safer to keep it separate, there is a small amount of duplication, but I can create follow ups to explore, this issue is more about just removing the hook_requirements.
dww
I know what's permitted to inject is different, which is why we have the whole separate class mechanism for install time. However, if the Install object is safe at install time, with less code loaded, surely it would work to use it at runtime with everything loaded