- Issue created by @Kristen Pol
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Bumping to major as this is likely to be part of the official xb-demo and we want it to look good.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Figma is noted here:
π [META] Create updated custom components for Starshot Demo Design System Fixed
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I'm going to split this into 2 issues... I'm going to get the config into this one so it's ready for styling by Alan for tomorrow.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
These are the header region placements
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
With that info ^ and comparing to civictheme.io, we should use header middle 2 for the logo and main nav and header middle 3 for the right info.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
We should do it closer to what's on Drupal.org since it's not quite the same as the designs.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Here's what it's looking like... now I need to get it into the config
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I may just merge this but I'll see if anyone is around to review.
How to test:
- Fresh vanilla D11 site (or Drupal CMS)
- Set up XB and SDDS per https://www.drupal.org/community-initiatives/starshot-demo-design-system... β
- Run
ddev drush recipe themes/contrib/demo_design_system/starshot_demo/recipes/starshot_demo_recipe_menus/
- You should have a header logo and menu structure link above (unstyled... styling will be with a frontend dev tomorrow)
If this works, the dev guide will need updating. As more recipes are added, we should be able to have one recipe that is dependent on the others though may have a hiccup with π Fix or workaround XB image alt bug that prevents saving SDDS components Active so may need to split that out.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Doing footer here:
β¨ Create SDDS global footer config Active
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I'm going to merge and keep going but still would be nice for others to try it in case there are some issues I didn't find
-
kristen pol β
committed 7bdf8461 on 1.0.x
Resolve #3510426 "Create sdds global"
-
kristen pol β
committed 7bdf8461 on 1.0.x
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Doing footer here:
β¨ Create SDDS global footer config Active
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
This and β¨ Create SDDS global footer config Active can be tested at the same time by using the latest dev code.
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
kristen pol β credited penyaskito β .
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
From penyaskito: missed the composer.json dependency to default_content... the starshot_demo theme depends on it on info.yml, but it's not in composer.json
- ππΊHungary GΓ‘bor Hojtsy Hungary
Similar to #3511866-14: Create SDDS global footer config β , I think there was a misunderstanding here? I think we would thruthfully demonstrate the current features of XB if there would be a general header region, rather than it being subdivided and a column (or header column) component placed to set the layout up there with menu blocks placed and the learn more button component placed within it.
- ππΊHungary GΓ‘bor Hojtsy Hungary
When a region is configured in XB, that is saved in page region config entities, NOT as block placement entities see https://git.drupalcode.org/project/experience_builder/-/blob/0.x/docs/co...
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Copying from footer issue:
Yeah, when I created these, I wasn't aware of XB's global placement workflow.
Block placement has been removed and regions simplified per:
π Remove block placement of SDDS header+footer blocks Active
π Too many global regions Activebut the content is still there.
Tweaks can be in the header/footer styling issues.