Too many global regions

I'd like for @alan.cole to chime in before this gets updated.

These regions are from CivicTheme and I agree they can be simplified but I'm worried about mucking with Alan's work today. I'm not sure what the hidden region is for.

I would need to refactor the default content and config I saved yesterday if we do this.

Assigning to Alan for thoughts.

This is to support this feature (the regions are supposed to show up in that list but I'm checking in Drupal slack to see why it's not showing up)

Okay... per @balintbrews and @gábor hojtsy:

You need to enable them at /admin/appearance/settings/[THEME]

Side note, if you do enable sidebar, it shows a gap on your page where the side bar is so you can't see it full width even if the sidebar is empty

I talked with Alan earlier today and he's okay with going with:

regions:
  header: 'Header'
  banner: 'Banner'
  highlighted: 'Highlighted'
  content: 'Content'
  sidebar: 'Sidebar'
  footer: 'Footer'

Though, this makes the styling harder because we have to create new components and/or update existing components to be able to make the header/footer look like they do.

Given this, hopefully, Alan will be able to finish the header today, but not sure he can do the footer today.

We'll need to:

1. Update regions in yml
2. Update config to use these regions or... see below

We might have to create the header/footer within XB and place them which means that they will only be part of the install if we get the home page saving to work. That is having issues because of an XB + default content bug that we'll have to work around by manually editing yml files to specify dependencies.

@gábor hojtsy Given all of this, you might need to use the placeholder/temp header/footer (images) for now to do your demos.

kristen pol → credited alan.cole → .

Note that @alan.cole updated the regions in this MR but leaving this open so we are still tracking:

✨ Add SDDS global header styling Active

Not sure what happened to the image above so re-attaching.

The philosophy of themes in the age of XB is that the theme will NOT provide these top, bottom, side, 1, 2, 3 regions, but the laying out of wider "Header", "Footer", etc. regions would be left to XB. So heaving a "Header top 1", "Header top 2", etc. are not demonstrating what the feature is meant to lead to. You would have a Header region and place a columns component there is you want to subdivide it, or more components above/below it if you need placement above/below. This would/will be the task of components not the theme. Hence this issue. I think this is fundamental to allow for ✨ Add SDDS global header styling Active and ✨ Create SDDS global footer config Active .

The sidebar is a similar situation but we probably want to sidestep that for now (maybe remove all sidebar options), since we don't have a good way to solve that and not enough time left :)

Thanks :)

The region simplification is part of ✨ Add SDDS global header styling Active as noted in #8...

But, I'm going to add an MR here to get this merged in now so we can close this one out and avoid further confusion.

I'll keep the sidebar off for now until we understand the UX better.

Updating summary to reflect new reality.

One more update

Merged in the changes.

add parent