Wrong title of installed button on recipe

Created on 21 January 2025, 3 months ago

Problem/Motivation

When a recipe is applied, button changes to Installed and it has title This module is installed.
This is not correct in case of recipes.

Steps to reproduce

Apply and recipe and check title of Installed button.

Proposed resolution

Currently, ProjectIcon.svelte has typeToImg constant values defined as per module. These all needs to be changed for any project. module can be replaced with package.

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇮🇳India narendraR Jaipur, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @narendraR
  • 🇮🇳India narendraR Jaipur, India
  • Pipeline finished with Failed
    3 months ago
    Total: 694s
    #401535
  • 🇺🇸United States chrisfromredfin Portland, Maine

    If you want to use a variant from a prop, you should change all of them and not just the 'installed' one. I think this is a good change, even if we don't capitalize on it immediately.

    I would replace "package" with "project" as the default variant.

  • First commit to issue fork.
  • Pipeline finished with Success
    2 months ago
    Total: 361s
    #404462
  • Pipeline finished with Success
    2 months ago
    Total: 609s
    #404466
  • 🇮🇳India shalini_jha

    I have addressed the feedback and made the necessary updates. The pipeline is green,
    so I am moving this to 'Needs Review.' Kindly review.

  • 🇬🇪Georgia lekso surameli

    Hey everyone, I'm going to review this MR as part of the ContributionWeekend2025

  • 🇬🇪Georgia lekso surameli

    Thank you all for your effort on this merge request

    After reviewing the changes, I’ve concluded that the current approach isn’t entirely valid or functioning as intended.

    The issue lies in the use of the variant prop. This prop is designed to control the display mode of the ProjectIcon component, but it’s currently being repurposed to represent the type of recipe. This approach doesn’t align with its intended purpose and leads to unintended side effects.

    Additionally, the variant prop currently supports two values: project-listing and module-details, each with separate associated CSS classes for styling. Overloading this prop with additional responsibilities could interfere with its primary purpose and the related styles.

    For example with these changes the tooltip for the icon looks like this:

    Because the value of variant prop is module-details.

    To address this, I recommend introducing a new prop specifically for controlling the type of recipe. This would make the component’s API more explicit and maintain the clarity and integrity of the existing variant prop.

    Let me know if you’d like to discuss this further

    I'm also changing the status of this ticket to Needs work

  • First commit to issue fork.
  • Pipeline finished with Success
    2 months ago
    Total: 493s
    #409058
  • 🇺🇸United States phenaproxima Massachusetts

    Didn't manually test but the code looks okay to me, and seems like a sensible change. The removal of the variant prop in favor of a generic term, at least for now, makes a ton of sense.

  • 🇺🇸United States tim.plunkett Philadelphia

    Saving credit

  • Pipeline finished with Canceled
    2 months ago
    Total: 282s
    #409394
  • Pipeline finished with Success
    2 months ago
    Total: 365s
    #409399
  • 🇺🇸United States tim.plunkett Philadelphia

    Merged !674 🎉

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    about 2 months ago
    Total: 1265s
    #429234
  • Pipeline finished with Failed
    about 2 months ago
    Total: 208s
    #429267
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1224s
    #429884
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1488s
    #429912
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1399s
    #430005
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1485s
    #430112
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1977s
    #433009
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1295s
    #433834
  • Pipeline finished with Success
    about 1 month ago
    Total: 1845s
    #433867
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1368s
    #435561
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1572s
    #436295
  • Pipeline finished with Canceled
    18 days ago
    Total: 317s
    #452936
  • Pipeline finished with Failed
    18 days ago
    Total: 1631s
    #452940
  • Pipeline finished with Failed
    18 days ago
    Total: 2022s
    #452971
  • Pipeline finished with Success
    18 days ago
    Total: 1783s
    #452994
  • Pipeline finished with Success
    18 days ago
    Total: 2569s
    #453073
  • Pipeline finished with Failed
    17 days ago
    Total: 1900s
    #453219
  • Pipeline finished with Success
    17 days ago
    Total: 1678s
    #453609
  • Pipeline finished with Success
    17 days ago
    Total: 1925s
    #453636
  • Pipeline finished with Failed
    17 days ago
    Total: 2563s
    #453893
  • Pipeline finished with Success
    17 days ago
    Total: 1437s
    #453959
Production build 0.71.5 2024