Merged π
Thanks for the review and suggestions @vasike
lekso surameli β created an issue.
Looks Awesome!
Thanks for the contribution @vasike
Thanks for the note @vasike, I have updated both task title and description
Merged π
@vasike thanks for the MR
@a.dmitriiev thanks for the review
lekso surameli β made their first commit to this issueβs fork.
LGTM
@vasike thanks for the MR
@a.dmitriiev thanks for the review
Thank you all for your effort on this merge request
After reviewing the changes, Iβve concluded that the current approach isnβt entirely valid or functioning as intended.
The issue lies in the use of the variant prop. This prop is designed to control the display mode of the ProjectIcon component, but itβs currently being repurposed to represent the type of recipe. This approach doesnβt align with its intended purpose and leads to unintended side effects.
Additionally, the variant prop currently supports two values: project-listing and module-details, each with separate associated CSS classes for styling. Overloading this prop with additional responsibilities could interfere with its primary purpose and the related styles.
For example with these changes the tooltip for the icon looks like this:
Because the value of variant prop is module-details.
To address this, I recommend introducing a new prop specifically for controlling the type of recipe. This would make the componentβs API more explicit and maintain the clarity and integrity of the existing variant prop.
Let me know if youβd like to discuss this further
I'm also changing the status of this ticket to Needs work
Hey everyone, I'm going to review this MR as part of the ContributionWeekend2025
Thank you for the work
After reviewing the code, I noticed that recipes are currently being sorted by machine_name rather than the human-readable name of the recipe. Sorting by name might provide a more user-friendly experience, as it's generally what end-users would expect to see
In this example bellow you can see how the Website feedback contact form appears before the Full HTML editor, this happens because the machine name of the first recipe is feedback_contact_form
@vishalkadam Thank you for reporting this issue! It has been addressed in the latest 1.0.0-alpha2 release.
In the meantime, support for Drupal 11 has been temporarily removed as we await the stable release of the webform module for Drupal 11.
lekso surameli β changed the visibility of the branch 3502222-add-module-logo to hidden.
lekso surameli β created an issue.
lekso surameli β made their first commit to this issueβs fork.