- Issue created by @phenaproxima
- πΊπΈUnited States mherchel Gainesville, FL, US
I'm guessing everything in drupal_cms_olivero is very temporary anyway.
So, sure? TBH, I have no clue how this will affect the end users.
- π¦πΊAustralia pameeela
@balintbrews said in Slack we can leave that out altogether:
(And about the status: stable , you can omit that from the component.yml file. It was put there in the early days as the team were working on the SDC discovery code.)
I've been removing it from the components based on this.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Fwiw, we used "experimental" for our components, but if leaving out works, then that's great. If you put "obsolete" then the component won't show up, which is handy when you don't want something to show up :) I prefer to have the status there in case I want to toggle something to obsolete and hide it, but that's because we were doing demo stuff and not "real stuff". For example, I regularly changed all the XB components to obsolete so they wouldn't show up.
- πͺπΈSpain ckrina Barcelona
+1to use experimental if that has an effect. I would assume everything related to XB is experimental until XB is stable
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Note that I've been marking the Olivero components as experimental as I update component MRs. But, XB has its own "stable" components still. And lots of "components" show up in XB from various places in Drupal CMS which makes the UI very cluttered and confusing at the moment. Obviously, this will be improved on in the coming months.
- πΊπΈUnited States phenaproxima Massachusetts
@kristen pol, did you sync your branches up with
1.x
? The drupal_cms_xb_demo recipe now disables all components except the ones in our Olivero subtheme, as of π Disable default XB components Postponed . Did wonders for decluttering, I'll tell you that much. - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Wow!!! That's so much better... and will be great after we get the components in over the coming weeks :)
A good follow-up is hiding the Fake Section and adding an Olivero one.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
We have two merged XB Olivero components so far:
- Heading: status was missing so I added it back as experimental for consistency
- Paragraph: already had status as experimental
All new component MRs can use the experimental status.
I think this issue can be closed after this tiny MR is merged.
I'll make a follow-up issue for hiding the section.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Follow-up issue: π Hide Fake Section 2 in XB and replace with Olivero section Active
- πΊπΈUnited States benjifisher Boston area
I am reviewing this issue at the Boston Drupal meetup. @phenaproxima, @pameela, and @dinarcon are here via Zoom. @mosheweitman, @charginghawk, and I are in the room, licking pizza off our fingers.
According to https://www.drupal.org/docs/develop/theming-drupal/using-single-director... β , SDC component metadata are in
components/*.component.yml
. I can search for that:$ find . -type d -name components ./drupal_cms_olivero/components ./drupal_cms_olivero/css/components $ find . -name '*.component.yml' ./drupal_cms_olivero/components/search-narrow/search-narrow.component.yml ./drupal_cms_olivero/components/paragraph/paragraph.component.yml ./drupal_cms_olivero/components/search-wide/search-wide.component.yml ./drupal_cms_olivero/components/heading/heading.component.yml
There are only CSS files in the
css/components/
directory.I looked at the four YAML files:
search-narrow.component.yml
: This file is empty (0 bytes). Can we delete it? Do I have to open a new issue to do that?paragraph.component.yml
: This one already hasstatus: experimental
.search-wide.component.yml
: This looks like a.libraries.yml
file, not a.component.yml
file.drupal_cms_olivero/components/heading/heading.component.yml
: This is the one fixed in the MR for this issue.
For convenience, here is the full content of
search-wide.component.yml
:libraryOverrides: dependencies: - core/drupal.autocomplete
I am not sure about
.libraries.yml
, but it is not a.component.yml
file.So the MR LGTM, and the only question is whether we need an issue for the two files that are not actually component metadatra. (Is there already an issue? Can we sneak the fixes in here or in some other issue?)
- πΊπΈUnited States phenaproxima Massachusetts
OK, definitely curious why we have zero-byte
*.component.yml
files lying around. The person who I think would know what the story is there is @mherchel. - πΊπΈUnited States benjifisher Boston area
In order to manage scope, I added π Search components need valid .component.yml files Active . I am moving this issue back to RTBC.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Thanks! And hope the pizza was good :)