- Issue created by @benjifisher
- πΊπΈUnited States benjifisher Boston area
Those files were all added in π Provide default styles for search Active . I am adding that as a related issue.
- πΊπΈUnited States mherchel Gainesville, FL, US
An empty *.component.yml file is valid when it belongs to a theme and is not overriding another component.
I'm not sure what the problem is?
- πΊπΈUnited States phenaproxima Massachusetts
I think we might have been missing the context in #3. (I was now years old when I learned this.)
Maybe we just add a comment in that YAML file to make it clear why it's there?
- πΊπΈUnited States benjifisher Boston area
I opened this issue after reviewing π Mark the XB components as experimental, not stable Active , which refers to https://git.drupalcode.org/project/experience_builder/-/blob/0.x/docs/co.... That doc says, in part,
3.1.1 Criteria for SDC components
For an SDC to be compatible/eligible for use in XB, it:MUST always have schema, even for theme SDCs
Looking at
core/lib/Drupal/Core/Theme/Component/ComponentValidator.php
, I see that SDC allows an empty metadata file, but it looks as though XB does not.Even without that, I think the reason in #5 is enough: add at least a name and description in order to avoid confusion.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I agree that some minimal info should be in there to avoid confusion and prevent future issues being created :)
- π¦πΊAustralia pameeela
Just noting this component isn't intended for XB. So if we add info just to avoid confusion, we'll need to ensure it doesn't result in the component actually appearing there.
- πΊπΈUnited States mherchel Gainesville, FL, US
It's not a big deal to add the schema, but my thought was since this isn't going to be used in XB, there's not much of a point. But #5 is valid. I don't want to confuse people.