Remove .ddev directory from composer create-project

This is critical, as we are shipping invalid DDEV config to people. Self-assigning to fix.

Back to @rfay for review!

This is looking good. I don't know how to manually test it, but I like it.

I would remove the `php_version`, `use_dns_when_possible` and `composer_version` lines from the provided config.yaml in the zipball. And I would change the `ddev_version_constraint` to `>= 'v1.24.0` just because we don't need to chase old weirdness that could crop up.

`php_version` 8.3 is default with current DDEV. And corepack_enable is true for drupal11 project type

It should be OK, it will get more eyeballs if deployed. Thanks for the quick action!

+1 for RTBC

Assigning to @tim.plunkett for final sign-off and commit.

tim.plunkett → credited pameeela → .

Based on my conversation with @phenaproxima, part of why it's affixed with .command was to make it clickable in MacOS. Except that regardless of what directory it is in, it runs in my home directory (~) and then fails.

I also discussed with @pameeela and she pushed back on using .command instead of the more common .sh

If this were the only CLI thing and we could actually make everything doable from a GUI, then I'd be all for it. But we still need the CLI to get DDEV running anyway.

So let's change this to launch-drupal-cms.sh and commit it. Unassigning myself so I don't block this while traveling.

This blocks Drupal CMS 1.0.0-rc2.

The sh `[ ]` format is shorthand for running the built-in `test` command. So `if [ -f /path/to/file ]` means `if test -f /path/to/file`

But the general use is `if somecommand` where success is `somecommand` returning 0. `test` is a special command.

`command` is part of the POSIX spec, so should work everywhere.

Added manual testing instructions per @rfay's request.

Following the steps provided in the issue summary i've first cloned the drupal_cms repo, applied the MR, and then copied the project_template directory into ~/Sites... I left the folder name as is and simply ran ./launch-drupal-cms.sh. the initial project start worked but on the composer create step i ran into an error because of the README.md file and the project folder not being clean

Failed to create project: '/Users/rkoller/Sites/project_template/README.md' is not allowed to be present. composer create needs to be run on a clean/empty project with only the following paths: [web web/sites web/sites/default web/sites/default/.gitignore web/sites/default/files web/sites/default/files/sync web/sites/default/settings.ddev.php web/sites/default/settings.php] - please clean up the project before using 'ddev composer create'

Oooh, great catch @rkoller. I adjusted the script to delete everything in the project root before DDEV spins up for the first time, and tested manually -- seems to work.

Adjusting manual instructions.

can confirm the install works now. i end up in the drupal cms installer when executing the shell script, which is the intended outcome.

and i will quickly test another round based on the updated new instructions.

I tested this repeatedly in
* WSL2
* macOS
* With the COMPOSER_CREATE set to use the temp special repo
* Without that.
* Introducing deliberate syntax errors into the script to simulate random errors.

I think it behaves quite well enough for our purposes right now, and it can mature as we get feedback.

I tried to test the script on macOs and the script doesn't install the Drupal CMS as expected. Below are the steps I followed as per IS.

1. git clone git@git.drupal.org:project/drupal_cms.git drupal-cms
2. cd drupal-cms
3. cp -r project_template cms-test
4. cd cms-test
5. `vi launch-drupal-cms.sh` and comment out `COMPOSER_CREATE=${COMPOSER_CREATE:-drupal/cms --stability="RC"}` and uncommnet
`export COMPOSER_CREATE='drupal/cms --stability=dev --repository={"type":"vcs","url":"https://github.com/phenaproxima/test-ddev-cms.git"}'`
6. Run ./launch-drupal-cms.sh from cms-test directory.

Then I got below error.

cms-test $./launch-drupal-cms.sh
it usually does not make sense to `ddev config` in a subdirectory of an existing project. Is it possible you wanted to `ddev config` in parent directory /Users/bhanu951/Projects/Contrib/drupal-cms?

@bhanu951, you have to get the test directory *outside* the repository, which has its own .ddev folder. Otherwise DDEV discovers the parent directory (as it told you) and refuses.

So copy the directory to ~/tmp/project-template or something.

When this gets deployed, the directory will be standalone, it won't be living as a part of this repository.

This is the script I've been using to create a new directory for testing:

#!/bin/bash

set -eu -o pipefail
set -x

ddev delete -Oy project-template
rm -rf ~/tmp/project_template && cp -r project_template ~/tmp

phenaproxima → credited hestenet → .

Merged into 1.x, and the relevant public pages (https://new.drupal.org/drupal-cms/release-candidate and https://www.drupal.org/project/drupal_cms → ) have been updated by @hestenet to give people the new launch command.

Whew!