Fix cspell eslint phpcs phpstan

Working on it.

Heyy @anybody,
I was resolving cspell errors and found the problem lies mostly in the term 'giftcards'.
Pipeline failure error log suggests to change it to 'giftcard' instead.
I think changing it will generate an error in th functionality.
So should I skip cspell or change the term?

@lavanyatalwar thanks. For "names" you could add a cspell ignore file to add these special words, like the module name.

If it's not the module name, it should be spaced:
Giftcard => Gift card
Giftcards => Gift cards

Okay
Should I fix phpunit errors as well?
Because I see some errors related to views as well (missing schema) that is not related to the this module.

Thanks, no that should be fixed in 🐛 Fix tests Active (that fix is already present)

@anybody
Now all the errors have been resolved.
Kindly check and merge :)

Really really GREAT work @lavanyatalwar thank you so much!

I left some comments to resolve. Would you also like to have a look at the fix tests issue afterwards?

Thanks @anybody
Sure I'll have a look on the issue you are refering.
Let me first resolve the comments on this issue.

@lavanyatalwar we can use _CSPELL_WORDS in case of few words are reported and you create .cspell-project-words.txt file to add all words as a dictionary in that file.

Please proceed with other feedback from @anybody

Thanks @ankitv18. I agree, I could have used that method.

When addressing spelling issues adding words to the dictionary should only happen for valid words.

For instance "fewfsfs" is part of an API key. This should not be added to the dictionary. Instead the the following should be appended to the line above the API key in the test
// cspell:disable-next-line

The address in the test "2630 Hegal Place" should be modified so it does not trip the spell checker.

The usage of "autofills" is incorrect. It should say "Chrome autofill incorrectly fills this field with address line 1" as that is clearer language.

Thank you for your feedback and input @rhovland! Learned something new today! Thanks!!

Thank you very very much @lavanyatalwar and @rhovland!!

Tested MR. Everything works as expected.

Is there anything else that needs addressed in this issue or is this good to go.

Thanks @rhovland great work!

I think it's fine, let's next fix the tests and schema in 🐛 Fix tests Active separately.

I'm going to merge this now, wonderful improvements!

Automatically closed - issue fixed for 2 weeks with no activity.