- Issue created by @Liam Morland
- 🇦🇺Australia acbramley
I would recommend holding off on all of these pipeline fixes until the D11 branch is merged. Otherwise we're going to have major conflicts which will be very hard to manage.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Many of these are needed for D11 compatibility. The D11 issue is being split into focussed issues. This issue could be part of that process.
- 🇦🇺Australia acbramley
@liam morland legitmate issues, sure, but making phpstan green in CI is not required for D11. The branch also needs a rebase with HEAD.
- First commit to issue fork.
- 🇳🇱Netherlands idebr
The phpstan pipeline is now fixed, but one test is now failing. Oddly enough it doesn't fail on my local machine.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Tests are passing again on 6.3.x. Please reroll and get tests to pass.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Tests are passing again on 6.3.x. Please reroll and get tests to pass.
- First commit to issue fork.
- 🇺🇸United States jrockowitz Brooklyn, NY
BTW, it fine to ignore a few tricky phpstan errors via
// @phpstan-ignore-next-line property.notFound
. - 🇺🇸United States jrockowitz Brooklyn, NY
BTW, it fine to ignore a few tricky phpstan errors via
// @phpstan-ignore-next-line property.notFound
. - 🇺🇸United States jrockowitz Brooklyn, NY
The failing test is only happening in D11.1
- Status changed to Needs review
about 2 months ago 3:38pm 24 March 2025 -
jrockowitz →
committed da4cb882 on 6.3.x authored by
ankitv18 →
Issue #3477942 by idebr, ankitv18, kul.pratap, jrockowitz, liam morland...
-
jrockowitz →
committed da4cb882 on 6.3.x authored by
ankitv18 →
- 🇺🇸United States jrockowitz Brooklyn, NY
I am going to go with this MR is good enough. The only breaking change is the removal of the completely unused
\Drupal\webform\Plugin\WebformElement\TextFormat::hasCompositeElement
added in 2017. -
jrockowitz →
committed da4cb882 on 6.x authored by
ankitv18 →
Issue #3477942 by idebr, ankitv18, kul.pratap, jrockowitz, liam morland...
-
jrockowitz →
committed da4cb882 on 6.x authored by
ankitv18 →
Automatically closed - issue fixed for 2 weeks with no activity.