- Issue created by @longwave
- First commit to issue fork.
- @spokje opened merge request.
- 🇳🇱Netherlands spokje
Let's start this with an MR for 11.x only for now to see what breaks.
- 🇳🇱Netherlands spokje
Unsure if this needs some manual testing before creating the back=port MRs, but I've run out of time for today anyway, so NR for now.
- 🇺🇸United States smustgrave
Applied locally for 11.x at least and didn't notice anything off.
- @spokje opened merge request.
- @spokje opened merge request.
- @spokje opened merge request.
- @spokje opened merge request.
- 🇳🇱Netherlands spokje
Thanks @smustgrave.
Added backport MRs:
10.2.x: MR !9706
10.3.x: MR !9705
10.4.x: MR !9704
11.0.x: MR !9703
11.x: MR !9702So this is where the fun starts...
We're making quite big bumps in 10.3.x and 10.2.x .
I remember that there were CKEditor5 bumps on the more current branches that needed to adjust tests to appease the new CKEditor5 versions.
Seems like, if we want to make this work, we need to backport these as well.I'm a bit unsure if we want to go through that effort for older branches and need some guidance on that.
Besides that the spellcheck job on 11.0.x seems borked on the GitLab side:, I've hit the below error regarding artifact uploading 4 times now:
Uploading artifacts for successful job 06:37 Uploading artifacts... core/node_modules/: found 250678 matching artifact files and directories ERROR: Uploading artifacts as "archive" to coordinator... 503 backend write error id=2914523 responseStatus=503 backend write error status=503 token=glcbt-64 WARNING: Retrying... context=artifacts-uploader error=service unavailable ERROR: Uploading artifacts as "archive" to coordinator... 503 backend write error id=2914523 responseStatus=503 backend write error status=503 token=glcbt-64 WARNING: Retrying... context=artifacts-uploader error=service unavailable ERROR: Uploading artifacts as "archive" to coordinator... 503 backend write error id=2914523 responseStatus=503 backend write error status=503 token=glcbt-64 WARNING: Retrying... context=artifacts-uploader error=service unavailable ERROR: Uploading artifacts as "archive" to coordinator... 503 backend write error id=2914523 responseStatus=503 backend write error status=503 token=glcbt-64 WARNING: Retrying... context=artifacts-uploader error=service unavailable ERROR: Uploading artifacts as "archive" to coordinator... 503 backend write error id=2914523 responseStatus=503 backend write error status=503 token=glcbt-64 WARNING: Retrying... context=artifacts-uploader error=service unavailable ERROR: Uploading artifacts as "archive" to coordinator... 503 backend write error id=2914523 responseStatus=503 backend write error status=503 token=glcbt-64 FATAL: service unavailable Cleaning up project directory and file based variables 00:59 ERROR: Job failed: command terminated with exit code 1
This might be a temporary thingy, so we might want to retry this a bit later.
- 🇳🇱Netherlands spokje
Bonus thought:
We might want to get 📌 Update Webpack to 5.94.0 Active in first, that one is all green and might cause merge conflicts with this one.
- 🇫🇷France nod_ Lille
Version 42.2.0 got out a few days ago but committing this since it's ready.
- 🇳🇱Netherlands spokje
If this needs backporting to 10.2.x, it's also gonna need some JS-test-fixes backported.
Unsure if we want to go through that amount of trouble for a Security Release that doesn't affect us?
I'll leave that question for core committers to ponder about. - 🇫🇷France nod_ Lille
and 10.3.x is not happy either I suspect the 10.3.x fix would fix 10.2.x too
- 🇬🇧United Kingdom catch
It looks like there's a version mismatch in the ckeditor5 alignment version on 11.0.x, see notes in 🐛 11.0.x yarn dependencies have mushroomed Active .
- 🇺🇸United States xjm
We had previously discussed for this issue that we would not backport this update to 10.2 unless CKSource could provide us a non-standard release on the old major that 10.2 was using, because the changes in CKEditor 5 v41 that were released in Drupal 10.3 broke a number of contributed modules. So this should only be backported to 10.2 if it also comes with a backport to CKEditor 40.
- 🇺🇸United States xjm
Adding @quietone to the credits since she also contributed to the ongoing RM discussions about this issue.
- 🇮🇩Indonesia el7cosmos 🇮🇩 GMT+7
el7cosmos → changed the visibility of the branch 3477799-bump-ckeditor5-10.3.x to active.
- 🇮🇩Indonesia el7cosmos 🇮🇩 GMT+7
el7cosmos → changed the visibility of the branch 3477799-bump-ckeditor5-10.3.x to hidden.
- 🇮🇩Indonesia el7cosmos 🇮🇩 GMT+7
I updated tests for 10.3 per #3459926-14: Update CKEditor 5 to 42.0.0 → . I have pushed the changes but can't reopen the MR, should I create a new MR?