- Issue created by @quietone
- π³πΏNew Zealand quietone
Restore some variables that should be removed in π Remove 2 unused class properties in tests Active
- πΊπΈUnited States smustgrave
Seems to be 1 open thread. that needs addressing (from you), maybe good for a first time user?
- πΊπΈUnited States smustgrave
Were any of the other changes reviewed?
Yes
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π³πΏNew Zealand quietone
I think the bot was wrong but I rebased anyway. There were no conflicts, so back to RTBC
- π³πΏNew Zealand quietone
Rebased and made changes for recently added code, so back to NR.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- πΊπΈUnited States smustgrave
Rebase seems good. Way more patient then myself to keep up with all these :)
- Status changed to Needs work
26 days ago 1:17am 3 January 2025 - π³πΏNew Zealand quietone
The conflict was with the phpstan baseline so I rebuilt it. Linting passes, so I am restoring the RTBC
-
larowlan β
committed 5ff536b2 on 11.x
Issue #3477669 by quietone: Fix VariableComment.Missing in tests but not...
-
larowlan β
committed 5ff536b2 on 11.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 11.x - thanks!
Automatically closed - issue fixed for 2 weeks with no activity.