Fix Drupal.Commenting.VariableComment.Missing in non-tests

There is no change to phpcs.xml.dist here due to the many files touched in 📌 Ignore VariableComment.Missing as needed Active and 📌 Add doc block for $modules in tests Active .

Should this be postponed on the other 2 landing first?

Ideally, yes. But the worse that will happen is that variables will be added without comment because phpcs.xml.dist can't be updated. That is likely to be a small number because the community is better at adding comments. So, I think it acceptable to take that risk of a few stragglers being fixed in the parent issue.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The other 2 are RTBC

Reviewing the changes here and additions make sense and seem fine.

Rebased and made changes for recently added code, so back to NR.

Rebase seems good.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Added an ignore line for the new file RecipeInputFormTrait.php

A couple remarks (nitpicks) on the MR.

Fixed the MR comments
Moving it to NR.

My remarks have been addressed.
All code changes look good to me.
For me it is RTBC.

There were phpcs errors, just whitespace, in the MR. I've pushed a fix for those.

All changes look good to me.
Back to RTBC.

larowlan → closed merge request !9687

Committed to 11.x - thanks!

Nice to see another rule enabled