Config Schema is missing the Notify schema

Suggested patch for review. Fixes the problem for me.

Added https://git.drupalcode.org/project/backup_migrate/-/blob/5.1.x/src/Core/...

Thanks for the important hint!

Mhm I'm wondering why CI doesn't complain here and I couldn't find backup_migrate.backup_migrate_settings.first_profile

We'll have a deeper look. I'm wondering why this didn't pop up earlier, the class and settings are not very young... https://git.drupalcode.org/project/backup_migrate/-/blob/5.1.x/src/Core/...

If you do not have a profile created, that config is not instantiated , and nothing is noticed. You need to create a first profile (forgot that in the steps), which will contain the undefined keys.

Thanks for the clarification @fgm! That's indeed an important step!

Changes LGTM! But we need to add an update hook resaving all custom profiles, otherwise we still get the following config inspector errors:

There are also further issues with the default "daily_schedule" schedule:

Thanks @Grevil. That means the values need to be resaved as boolean from integer in #9
And from string to integer in #10

No idea, why "keep" is defined as a text field, expecting numbers and the schema defines it as an integer. We could also clear that up here.

Yes, and I guess we should also use "number" instead of "textfield" as the form element type.

Yes, let's include this in the 5.1.0 release. It's almost there.

@fgm could you eventually find time to finish this, so 5.1.0 can finally see the daylight?

No, I thought you were doing it so didn't look further. I might have some time this weekend.

sudhanshu0542 → made their first commit to this issue’s fork.

@fgm, @anybody and @grevil, I made some changes regarding the "keep". This resolves the validation error.

@sudhanshu0542 I'm not sure that we need to remove "keep" from config, but

keep: null

fixed the schema error

Looks like RTBC. I don's see any config inspector errors.

All tests passed on local

All tests passed on local

Same here! Couldn't replicate the test failure on both D11 nor D10. Unfortunately, we should investigate the error anyway, as Damien won't push an MR containing failing CI jobs.

I don's see any config inspector errors.

You probably had no custom profiles before updating? Without the schema definition the schema defaults to using integers instead of boolean, so we definitely still need that update hook I mentioned in #9 🐛 Config Schema is missing the Notify schema Needs work .

@damienmckenna I'd vote to not include this in 5.1.0. There's still no Drupal 11 compatible stable release and there's not much community activity on this issue, I think because it's not that important for many...

Should this really be a blocker?

Yeah, while I'd love to include this, I don't know why it's failing on gitlab but works locally for me too.

I think the two email fields could be left as a string, to allow for multiple values, local-only usernames, etc:

            notify_success_email:
              type: email

i.e. only admins should be setting that, so let's leave it more open.

@damienmckenna maybe ask in Slack if someone has an idea, why it fails here?