Drupal.dialog openDialog should use event settings

Thanks that was an oversight in the initial patch

Change seems small enough that doesn't need test coverage I would say.

nod_ → closed merge request !9406

Double checked it turns out the altered settings is working in the current code, this makes it more explicit and remove any ambiguity as to the intent. I think this was a problem when using CustomEvent instead of our own event class, in any case not a bug, but core is more maintainable.

Committed and pushed d075b6c360 to 11.x and b95fd40e05 to 11.0.x and ff33b01fc4 to 10.4.x and 65a3907d98 to 10.3.x. Thanks!

Thanks for the quick merge.

Could you also credit https://www.drupal.org/u/tocab → who was the one finding the problem please?

Automatically closed - issue fixed for 2 weeks with no activity.