- Issue created by @Grimreaper
- @mademo opened merge request.
- Assigned to mapac
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:40pm 27 June 2023 - Status changed to Needs work
over 1 year ago 11:05am 3 July 2023 - Assigned to mapac
Usage :
href="[some-links]"
class="use-ajax"
data-dialog-type="modal"
data-dialog-options="{"dialogClasses":"modal-dialog-centered","dialogShowHeader":false}"
>
Open modal
Dialog options :
dialogClass => string
dialogShowHeader => boolean
dialogShowHeaderTitle => boolean
dialogStatic => boolean
dialogHeadingLevel => number- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 2:24pm 4 July 2023 - Assigned to Grimreaper
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 4:23pm 5 July 2023 - Assigned to Grimreaper
-
Grimreaper β
committed a910ce3b on 5.0.x authored by
mademo β
Issue #3368697 by Grimreaper, mademo: Replace Core modal by Bootstrap...
-
Grimreaper β
committed a910ce3b on 5.0.x authored by
mademo β
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 9:12pm 30 August 2023 - Assigned to Grimreaper
- Status changed to Needs work
over 1 year ago 3:18pm 11 September 2023 - π«π·France Grimreaper France π«π·
The change introduced here prevents Layout Builder to work.
error occurred during the execution of the Ajax response: TypeError: Converting circular structure to JSON --> starting at object with constructor 'Window' --- property 'window' closes the circle (
I will rollback.
-
Grimreaper β
committed fa5b80ee on 5.0.x
Issue #3368697 by Grimreaper: Rollback change until compatibility with...
-
Grimreaper β
committed fa5b80ee on 5.0.x
- Issue was unassigned.
- Merge request !188Issue #3368697 by Grimreaper, nod_: Fix JS error when using Layout Builder. β (Merged) created by Grimreaper
- π«π·France Grimreaper France π«π·
Thanks to @nod_, MR 188 created that fixes one JS error. Now it works but, in Layout Builder, the offcanvas is replaced by the modal and also some other JS is not applied due to wrong execution order.
Needs deeper investigation.
- First commit to issue fork.
- Assigned to Grimreaper
- Status changed to Needs review
5 months ago 2:46pm 4 September 2024 - π«π·France maboy
Hello,
I've tested tocab fix on my side and off canvas modal is now working as expected (cf off-canvas.png)
Regards,
- π«π·France Grimreaper France π«π·
I will split the offcanvas into a dedicated issue because I need to remove/adjust development to override properly form in Layout Builder or not and still ensure it works with Gin LB.
-
grimreaper β
committed 3ed99bfc on 5.0.x
Issue #3368697 by grimreaper, mademo, tocab, maboy, nod_: Replace Core...
-
grimreaper β
committed 3ed99bfc on 5.0.x
Automatically closed - issue fixed for 2 weeks with no activity.