- Issue created by @marc.bau
- ๐ณ๐ฟNew Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- First commit to issue fork.
- Status changed to Needs review
3 months ago 6:41am 18 September 2024 - ๐ฎ๐ณIndia nayana_mvr
The issue is reproducible in Drupal 11.x version. I have created an MR with the proposed solution. I didn't change
display: block; margin-block: var(--sp0-5);
because I think it is as per Olivero theme style and doesnโt require any change. I have used variable
--line-height-s
forline-height
property since the variable used in Claro is specific to Claro theme and it won't work for Olivero. Kindly review the changes. The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ฎ๐ณIndia sagarmohite0031
Hello,
Not able to reproduce this issue looks fine before and after MR apply.Attached screenshots-
- ๐ฎ๐ณIndia nayana_mvr
@sagarmohite0031 As mentioned in the steps to reproduce,
Open node edit form with Oliviero
So change the admin theme to Olivero in
/admin/appearance
and then check the node edit page. - ๐ซ๐ทFrance nod_ Lille
Can I have screenshots for the comment section of an article? Olivero is not an admin theme so making the node/edit page looks good is not a priority. But if it impacts the comment form then it's a different topic.
Can you add one or two field to the comment entity to check how non-default comment fields are impacted by this MR? thanks!
- ๐ฎ๐ณIndia nayana_mvr
Please find the before and after MR screenshots of comment section of an article.
Before:
After:
I tried adding a Date and Mail id field to the comment entity and this is how it looks like after the MR changes:
- ๐ฎ๐ณIndia sagarmohite0031
Hello nayana_mvr,
I have verified this issue on Drupal 11.x version with Oliviero.
Still not able to reproduce.Please check Attachments-
- ๐ฎ๐ณIndia nayana_mvr
@sagarmohite0031 Please change the admin theme to Olivero and then verify again.
From the attached recording, I can see youโre still using Claro theme as admin theme.
- ๐ฎ๐ณIndia sagarmohite0031
Hello nayana_mvr,
Thanks for the screenshots and sorry for misunderstanding now I'm able to reproduce issue.
The MR is applied successfully.Changes looks good.
Hello @nod_,
Please verify attached screenshots for comment Before and After. - ๐ฉ๐ชGermany marc.bau
Comment looks also correct per screenshots.
Admin theme or not, node edit form need to look correct.
Automatically closed - issue fixed for 2 weeks with no activity.