Contrib.social

vary header from response is removed by CorsService.php

Open on Drupal.org →
Created on 2 September 2024, 7 months ago

We have an event subscriber which adds 'referer' string in vary header in the response .

CorsService.php removes our vary header from the below code

public function varyHeader(Response $response, $header): Response
    {
        if (!$response->headers->has('Vary')) {
            $response->headers->set('Vary', $header);
        } elseif (!in_array($header, explode(', ', $response->headers->get('Vary')))) {
            $response->headers->set('Vary', $response->headers->get('Vary') . ', ' . $header);
        }

        return $response;
    }

Note: Page cache module is disabled.

Steps to reproduce

1.Add event subscriber in the custom module. Subscriber to kernel response event to add vary header.

public static function getSubscribedEvents() {
    $events[KernelEvents::RESPONSE][] = ['onRespond'];
    return $events;
  }
 public function onRespond(ResponseEvent $event): void {
    $response = $event->getResponse();
    $response->setVary('Referer', FALSE);
    }
  }

2. When we load the page and inspect it, referrer from the vary header is missing.

Proposed resolution

$events[KernelEvents::RESPONSE][] = ['onRespond' ,1];
If we give it a priority,it resolves the issue but then it removes cookie vary header.

🐛 Bug report
Status

Active

Version

10.2 ✨

Component
Other  →

Last updated about 23 hours ago

Created by

🇮🇳India drupalite1411

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024