- Issue created by @catch
- Status changed to Needs review
3 months ago 1:47pm 22 August 2024 - Status changed to RTBC
3 months ago 1:04pm 23 August 2024 - πΊπΈUnited States smustgrave
Seems straight forward with no loss of test coverage
1) Drupal\Tests\block\Functional\BlockCacheTest::testCachePerPage Behat\Mink\Exception\ResponseTextException: The text "wzdcjged" appears in the text of this page, but it should not. /builds/project/drupal/vendor/behat/mink/src/WebAssert.php:907 /builds/project/drupal/vendor/behat/mink/src/WebAssert.php:312 /builds/project/drupal/core/modules/block/tests/src/Functional/BlockCacheTest.php:235
Appears random.
Observed unrelated test failures, it was unrelated to recent changes so run pipeline, pipeline passed , MR is mergeable now,
Changes looks good: used protected from public along with relevant changes included to call those protected methods & removed dataProvider, apart from nothing seems to be left, verified test changes on local, its output on the basis of time & memory usage as follow:
Before applied MR changes test takes : Time: 01:58.561, Memory: 6.00 MB
After applied MR changes test takes: Time: 01:26.928, Memory: 6.00 MB
observed test & its resources usage improved & attached screenshot as well, moving to RTBC
- π³πΏNew Zealand quietone
Unfortunately, this makes tests that are difficult to debug even harder to debug. With the dataprovider the standard output will include the case that failed and now there is nothing to indicate which of the current 8 cases is causing the failure.
Oh no, I see that π Speed up UpdateSemverTestSecurityAvailabilityTrait Fixed has been committed and that this has been done to the other security related update tests. I wish I had seen this earlier.
So, I think a follow up is needed to.at least, add messages to all the assertions to report the details of which case is being tested. And it should be a Critical issue, because of the regression in the developer experience and this is about the update messages.
- π«π·France nod_ Lille
Committed and pushed 6d66158e05 to 11.x and 11b1127559 to 11.0.x and 1bdf2bda42 to 10.4.x and a1a6e7acfb to 10.3.x. Thanks!
- Status changed to Fixed
3 months ago 9:08am 27 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- π³πΏNew Zealand quietone
Follow up was made π [meta] Add messages to assertions in a loop in sped up tests Active