Navigation shown on prints (landscape only)

manibharathi ezhimalai ravi → made their first commit to this issue’s fork.

Hi,
I have created the MR !9351 for this feature.

Thanks for reporting but fixes should be against the 11.x branch as the current development branch

Thanks.

Thank you for the fix. I hope it get backported as v11 is not an option for next months.

manibharathi ezhimalai ravi → changed the visibility of the branch 3468755- to hidden.

Hi,
I have created the MR !9368 for the Branch 11.x.

First thanks for trying out the new Navigation.

If I print a page in admin area in portrait mode it does not show the navigation in prints. If I change the layout to landscape mode, the prints also shows the navigation bar.

This might be related to the viewport?

The navigation should not shown on prints at all.

Why shouldn't it? Which is the user need, the justification behind it?

We can't make this kind of assumptions without actually reasoning them :)

It is common that print views only who useful content and not navigations. If you need the navigation for documentation reasons or mockups you can make screenshots and print these. But in all other cases a user like to print the page content and not navigations bars.

@ckrina there is precedent for this in the toolbar module. It has print styles to hide the toolbar for @media print:

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/toolb...

Do you think that is reason enough to do the same thing for Navigation module as well? To be sure, it doesn't look like there was a very robust discussion for/against this in the issue where it was added. See #2403639: Remove toolbar from print view → .

The usual reason to 'print' a webpage is to save a long article as a PDF using print-to-PDF either to read offline or to convert to a more easily readable format. For this use-case you would want as little site chrome as possible, just the text and images from the main body content.

I don't think there's any use case for physically printing (or PDF printing) a web page as it actually looks with admin-only navigation elements, so makes sense to remove that.

On the MR itself, I don't think it needs an @media print in the file - that ought to be handled in the library definition given it's already a separate file?

rinku jacob 13 → made their first commit to this issue’s fork.

I created a new branch because I encountered conflict errors when trying to check out to the old branches. also, in the previous MR, no SCSS file was created. We need to create the SCSS file, and after compilation, it will automatically generate the CSS file. Based on the comments in the catch, I have made some changes to my MR