Implement the File Sanitization in a Separate Service to Make it More Reusable

MR should be against 11.x

Most likely will have some backwards compatibility impact so will have to deal with that.

arunkumark → changed the visibility of the branch 3468722-implement-the-file-name-sanitization-in-separate-service- to hidden.

As per feedback #4 the branch for 10.x is hidden. Created new PR for 11.x version.

NW for linting fails.

Tested the patch in the local PHPUnit it working fine. Attached screenshot for reference,

The failure might be of 📌 Bump phpstan/phpstan to latest to make daily "updated deps" QA run pass again Fixed . It was tracked on 🐛 Updated deps job fails Needs review . Hope there is no action required on the MR.

@kim.pepper please change the status if you have a different opinion.

Don't think those two issues are related. Error is:

 ------ -------------------------------------------------------------- 
  Line   core/modules/file/src/FileSanitizeName.php                    
 ------ -------------------------------------------------------------- 
  79     Call to preg_quote() is missing delimiter / to be effective.  
  79     Call to preg_quote() is missing delimiter / to be effective.  
 ------ -------------------------------------------------------------- 

You need to add a service alias for 'Drupal\file\FileSanitizeName' => 'file.sanitize_name'

I think the name FilenameSanitizer makes more sense.

Can you also describe the use case where this would be used outside of the event handler?

As per teh suggestion #14 the Filename updated.

use case where this would be used outside of the event handler

If any user wants to change the Filename, there is no need to override the Event subscriber. Instead, they can extend the service class and make their changes.

Pipeline appears to be having failures.