- Issue created by @spokje
- 🇳🇱Netherlands spokje
Hmm, confused now:
1) Drupal\PHPStan\Tests\EnsurePHPStanVersionsMatchTest::testVersions Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'1.11.7' +'1.11.8' /builds/issue/drupal-3463954/core/tests/PHPStan/tests/EnsurePHPStanVersionsMatchTest.php:17
vs
https://git.drupalcode.org/project/drupal/-/merge_requests/8938/diffs#14...
- 🇳🇱Netherlands spokje
Unconfused myself, it problem lies in the other file of the comparison:
core/tests/PHPStan/composer.json
.Shouldn't that file be updated automagically when bumping PHPStan in the root
composer.json
?
Is this worth a follow-up? - Status changed to Needs review
5 months ago 9:39am 26 July 2024 - Issue was unassigned.
- Status changed to RTBC
5 months ago 2:03pm 26 July 2024 - 🇺🇸United States smustgrave
Overall didn't appear to be a lot of missed stuff. Seems pretty straight forward
- 🇺🇸United States xjm
For this to be RTBC, we need to prove that it actually solves the problem, eh? ;)
I manually queued the updated deps job for the MR at:
https://git.drupalcode.org/issue/drupal-3463954/-/pipelines/238845Note that I had to click the button for push access to do this, despite being a project maintainer. Before that, I got this super helpful error message:
An error occurred while making the request.
- 🇺🇸United States xjm
Results:
https://git.drupalcode.org/issue/drupal-3463954/-/pipelines/238845The PHPStan job for updated deps is passing there, but PHPUnit tests failed. Looking into it.
- 🇺🇸United States xjm
Failure is:
Problem 1 - Root composer.json requires drupal/core-recommended ^11 -> satisfiable by drupal/core-recommended[11.0]. - drupal/core-recommended 11.0 requires guzzlehttp/guzzle ~7.8.1 -> found guzzlehttp/guzzle[7.9.2] but it does not match the constraint. Failed asserting that 2 matches expected 0.
That... sounds like a problem in the updated deps test logic. I could not find an existing issue.
We could maybe go ahead and commit this regardless, since it makes static analysis work, but I'm scratching my head a bit about how the composer install could work for static analysis but fail for PHPUnit. Going to try requeuing that job to verify that I get the same result....
- 🇬🇧United Kingdom catch
I'm also confused by those composer errors in the build job, but this is a good step forwards so think we should go ahead here. Committed/pushed to 11.x, thanks!
- Status changed to Fixed
5 months ago 12:30pm 31 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇫🇷France andypost
I gonna backport it to 10.4 as it become a blocker for composer updates for PHP 8.4 📌 upgrade phpstan to 1.11.10 for 10.4.x Active