- Issue created by @catch
- Status changed to Needs review
4 months ago 1:39pm 31 July 2024 - 🇬🇧United Kingdom catch
Just trying the guzzle update to see if the job passes with that.
- 🇳🇱Netherlands spokje
So this seems to pass (let's pretend the JS error didn't happen, seems like a random
stale element-yadayada).What the deal is with the config validation having a (far too low) DB version, I don't know.
Is this job outdated? Does it still work on a "normal" MR? - 🇳🇱Netherlands spokje
Come to think of it, before the recent changes in the build-phase, we did a
composer installin the main build, and in the specific updated deps run, we did something along the lines of acomposer update -Won top of that.I can't find that last bit in the current output, but I'm very unfamiliar with how the current setup works by now.
Could somebody point me in the right direction, there must be output of what's been updated somewhere in there? - 🇳🇱Netherlands spokje
Aaand even more thoughts: Should we do a (full) composer dependency update?
Currently we're missing out on the 7.1.3 release of Symfony. - 🇬🇧United Kingdom catch
@Spokje
Come to think of it, before the recent changes in the build-phase, we did a composer install in the main build, and in the specific updated deps run, we did something along the lines of a composer update -W on top of that.
I can't find that last bit in the current output, but I'm very unfamiliar with how the current setup works by now.
It's still in there, just slightly hidden. We use the composer/yarn artifacts from the phpcs and spell checking jobs, instead of having dedicated composer and yarn building jobs now. But the actual test runs pull those artifacts in the same way, just from differently named jobs.
.with-composer-and-yarn: &with-composer-and-yarn needs: - pipeline: $PARENT_PIPELINE_ID job: '🧹 PHP Coding standards (PHPCS)' - pipeline: $PARENT_PIPELINE_ID job: '📔 Spell-checking'Those jobs still run composer update when needed, like:
https://git.drupalcode.org/project/drupal/-/jobs/2295372So theoretically there shouldn't be a big change, but the mismatch with the guzzle update does seem newish.
Should we do a (full) composer dependency update?
Currently we're missing out on the 7.1.3 release of Symfony.
Yes I think that's a good idea.
- Status changed to Needs work
4 months ago 1:02pm 1 August 2024 - 🇺🇸United States smustgrave
Should we do a (full) composer dependency update?
Currently we're missing out on the 7.1.3 release of Symfony.
Yes I think that's a good idea.Assuming that will address the test failure.