Updated deps job fails

Created on 31 July 2024, 5 months ago
Updated 1 August 2024, 5 months ago

Problem/Motivation

The updated deps job fails on build tests: https://git.drupalcode.org/project/drupal/-/jobs/2290402

our requirements could not be resolved to an installable set of packages.
  Problem 1
    - Root composer.json requires drupal/core-recommended ^11 ->
satisfiable by drupal/core-recommended[11.0].
    - drupal/core-recommended 11.0 requires guzzlehttp/guzzle ~7.8.1 ->
found guzzlehttp/guzzle[7.9.2] but it does not match the constraint.
Failed asserting that 2 matches expected 0.
/builds/project/drupal/core/tests/Drupal/BuildTests/Framework/BuildTestBase.php:305
/builds/project/drupal/core/tests/Drupal/BuildTests/Framework/B

I think this might be because core/composer.json allows guzzle to be updated to 7.9, but core-recommended is pinned to 7.8

If we update core to guzzle 7.9 it might pass again, not sure how much effort we want to put into debugging the test in its own right.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component
ComposerΒ  β†’

Last updated 6 days ago

No maintainer
Created by

πŸ‡¬πŸ‡§United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @catch
  • Merge request !8998Update guzzle. β†’ (Open) created by catch
  • Status changed to Needs review 5 months ago
  • πŸ‡¬πŸ‡§United Kingdom catch

    Just trying the guzzle update to see if the job passes with that.

  • πŸ‡³πŸ‡±Netherlands spokje

    So this seems to pass (let's pretend the JS error didn't happen, seems like a random stale element-yadayada).

    What the deal is with the config validation having a (far too low) DB version, I don't know.
    Is this job outdated? Does it still work on a "normal" MR?

  • πŸ‡³πŸ‡±Netherlands spokje

    Come to think of it, before the recent changes in the build-phase, we did a composer install in the main build, and in the specific updated deps run, we did something along the lines of a composer update -W on top of that.

    I can't find that last bit in the current output, but I'm very unfamiliar with how the current setup works by now.
    Could somebody point me in the right direction, there must be output of what's been updated somewhere in there?

  • πŸ‡³πŸ‡±Netherlands spokje

    Aaand even more thoughts: Should we do a (full) composer dependency update?
    Currently we're missing out on the 7.1.3 release of Symfony.

  • πŸ‡¬πŸ‡§United Kingdom catch

    @Spokje

    Come to think of it, before the recent changes in the build-phase, we did a composer install in the main build, and in the specific updated deps run, we did something along the lines of a composer update -W on top of that.

    I can't find that last bit in the current output, but I'm very unfamiliar with how the current setup works by now.

    It's still in there, just slightly hidden. We use the composer/yarn artifacts from the phpcs and spell checking jobs, instead of having dedicated composer and yarn building jobs now. But the actual test runs pull those artifacts in the same way, just from differently named jobs.

    .with-composer-and-yarn: &with-composer-and-yarn
      needs:
        - pipeline: $PARENT_PIPELINE_ID
          job: '🧹 PHP Coding standards (PHPCS)'
        - pipeline: $PARENT_PIPELINE_ID
          job: 'πŸ“” Spell-checking'
    

    Those jobs still run composer update when needed, like:
    https://git.drupalcode.org/project/drupal/-/jobs/2295372

    So theoretically there shouldn't be a big change, but the mismatch with the guzzle update does seem newish.

    Should we do a (full) composer dependency update?
    Currently we're missing out on the 7.1.3 release of Symfony.

    Yes I think that's a good idea.

  • Status changed to Needs work 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Should we do a (full) composer dependency update?
    Currently we're missing out on the 7.1.3 release of Symfony.
    Yes I think that's a good idea.

    Assuming that will address the test failure.

Production build 0.71.5 2024