Attach Ajax dialog library for Views Entity Operations

1. Extended \Drupal\Tests\node\FunctionalJavascript\NodeDeleteConfirmTest::testNodeDelete with a delete operation from Views
2. Attached the Ajax dialog library for Views Entity Operations
3. Converted waitForText() to pageTextContains() to actually assert the element is displayed on the page

Sounds like a feature that probably needs some test coverage.

Also see that the tests had to be updated makes me wonder if this is going to be a breaking change for some sites.

Test coverage is available, see https://git.drupalcode.org/project/drupal/-/blob/d7b77f1cb94fa938ab984e2...

Considering the Ajax dialog is already active for many sites (see Problem/Motivation), the disruption is minimal.

Nice, this gets Views inline with the changes intended in 📌 Use a modal for entity delete operation links Fixed . Solution looks good, test coverage looks good (couple of unrelated code cleanup changes I guess, but ¯\_(ツ)_/¯)

Had a look at this. I wondered if we could add the dialog library only when there is a link that uses a modal, but after looking at it, the current EntityListBuilder implementation doesn't try to do that, and this isn't supported by #theme links which is what these operations ultimately turn into.

To make that work, we'd have to make each link a render array that support #attached, then the delete link could handle that itself. Opened 📌 Allow links passed to #theme links to support #attached Active to explore this.

Committed/pushed to 11.x, thanks!

catch → closed merge request !8970

Automatically closed - issue fixed for 2 weeks with no activity.