- Issue created by @lauriii
- Status changed to Needs review
over 1 year ago 6:24pm 1 June 2023 - last update
over 1 year ago 29,402 pass - Status changed to RTBC
over 1 year ago 6:29pm 1 June 2023 - 🇺🇸United States smustgrave
Confirmed on 11.x
Applied patch and cleared cache and the button is good again.
- last update
over 1 year ago 29,402 pass - 🇺🇸United States dww
Mostly looks great, thanks! Simplified the @todo comment down to 1 line. Leaving RTBC. Tagging.
Thanks again,
-Derek - Status changed to Fixed
over 1 year ago 9:03pm 1 June 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
Seems familiar! This was likely due to 📌 Use a modal for entity delete operation links Fixed , because I found that exact problem there, it got addressed, then apparently got unaddressed. The dialog assets definitely have to be loaded with the rest of the page otherwise the async load messes up precedence.
Doing it in claro.theme is probably the optimal way to deal with the issue vs embedding it earlier when it isn't really needed. It is also much better than reverting that nice UX improvement.
Happy this got spotted when it did.
Automatically closed - issue fixed for 2 weeks with no activity.