hook_form_field_config_edit_form_alter receives field definition with wrong required value

Created on 26 July 2024, 6 months ago

Updated 1 August 2024, 6 months ago

Problem/Motivation

\Drupal\Core\Field\FieldItemList::defaultValueWidget() changes the required and description values of the field definition while rendering the default values form, but the problem is that these values aren't restored after rendering, which means that any code coming after this receives wrong description and required values when reading from the field definition. This was discovered in a contrib module reading the required value: 🐛 Required checkbox has the wrong value when using the default (Core) Required API plugin Needs review .

Steps to reproduce

Implement hook_form_field_config_edit_form_alter and read the required value. It will always be false.

Proposed resolution

Clone the field definition object before modifying.

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Base →

Last updated about 5 hours ago

Maintained by
🇺🇸United States @effulgentsia
🇬🇧United Kingdom @catch
🇬🇧United Kingdom @alexpott
🇦🇺Australia @larowlan
🇺🇸United States @bnjmnm
🇫🇷France @nod_
🇪🇸Spain @ckrina
🇬🇧United Kingdom @justafish

Created by

🇧🇪Belgium dieterholvoet Brussels

Live updates comments and jobs are added and updated live.

Merge Requests

!8942hook_form_field_config_edit_form_alter receives field definition with wrong required value
Open
🇧🇪Belgium dieterholvoet
updated 6 months ago

Comments & Activities

Issue created by @dieterholvoet
Merge request !8942Clone the field definition object before modifying. → (Open) created by dieterholvoet
Issue was unassigned.
Status changed to Needs review 6 months ago2:01pm 26 July 2024
Comment 6 months ago →
🇧🇪Belgium dieterholvoet Brussels
Pipeline finished with Failed
6 months ago
Total: 484s
#234858
Status changed to Needs work 6 months ago2:13pm 26 July 2024
Comment 6 months ago →
🇧🇪Belgium dieterholvoet Brussels
Seems to be a failing field_ui test, I'm going to do some more manual testing to make sure the clone addition doesn't break anything.
Comment 6 months ago →
🇧🇪Belgium dieterholvoet Brussels
I tested manually and the default value form still seems to be working fine. I can't figure out what's wrong with the automated testing, maybe somebody else can.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024